Fix/test app rp openid configuration #1362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dopry
commented
Nov 10, 2023
•
dopry
commented
- CORS wasn't configured for discovery endpoint
- origins were not set for the application in the IDP
- the rp used 127.0.01 and localhost inconsistently when referring to the issuer, standardized to localhost
(cherry picked from commit a592988)
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 32 32
Lines 2120 2120
=======================================
Hits 2068 2068
Misses 52 52 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
dopry
force-pushed
the
fix/test-app-rp-openid-configuration
branch
2 times, most recently
from
447ed3d to
1f9667d
Compare
dopry
force-pushed
the
fix/test-app-rp-openid-configuration
branch
from
b5985bc to
9b1e164
Compare
n2ygk
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.