Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast int cookie dict max_age #185

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Cast int cookie dict max_age #185

merged 2 commits into from
Oct 21, 2024

Conversation

andruten
Copy link
Member

@andruten andruten commented Feb 8, 2024

May fix #161

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.84%. Comparing base (e7ad0c2) to head (1d80f40).

Files with missing lines Patch % Lines
revproxy/utils.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   98.55%   97.84%   -0.71%     
==========================================
  Files           7        7              
  Lines         414      418       +4     
  Branches       70       70              
==========================================
+ Hits          408      409       +1     
- Misses          3        6       +3     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfourie
Copy link

dfourie commented Sep 6, 2024

Hi there, I did encounter that bug as well, this branch fixes it.

@andruten andruten merged commit bf8b4f7 into master Oct 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of "max-age" attribute of HTTP Cookie
3 participants