-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default tag ordering to the primary key #892
Merged
Merged
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
f5ba4b5
add TestTaggableManager
steverecio d96a216
fix _to_tag_model_instances to preserve order
steverecio e0c8858
ensure tag order is preserved
steverecio 0595a42
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5820930
missing arg
steverecio 122112b
clean up tests
steverecio 9697a97
fix conditional on ordering arg
steverecio 897ed6a
make test more explicit
steverecio cb7d00c
fix case insensitive handling and tag_kwargs
steverecio 0a8378b
fix processing logic
steverecio b297551
fixed duplicates issue
steverecio 311c1e4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 82922eb
fix most_common test
steverecio 8bfa7ed
a more elegant solution of imposing through table ordering only if fi…
steverecio acff592
unused import
steverecio b23715b
Make sure to only query as much as needed
rtpg e203e07
Add changelog entry
rtpg 5ba5934
Add note to tricky code
rtpg 855def6
fix style issues
rtpg 15d83bc
ignore .direnv for flake8
rtpg 1e70249
Add Steve to the AUTHORS
rtpg e4baf49
remove continue usage
rtpg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Recio 😎