Enable Tag Merging #904
Merged
Enable Tag Merging #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Selected tag ids are appended to url query parameter - tag ids are store in the session temporaily - tags are merged into new tag name - session is cleared of the tag IDs
for more information, see https://pre-commit.ci
…to 899-merge-tags
for more information, see https://pre-commit.ci
rtpg
reviewed
Jul 14, 2024
rtpg
reviewed
Jul 14, 2024
rtpg
reviewed
Jul 14, 2024
- We do not need to get the tag ids from the query params - Instead we just grab from session data
…to 899-merge-tags
rtpg
reviewed
Jul 17, 2024
rtpg
reviewed
Jul 17, 2024
rtpg
reviewed
Jul 17, 2024
rtpg
reviewed
Jul 17, 2024
rtpg
reviewed
Jul 17, 2024
- Updated the success message to user - cleaned up some print statements - updated the form max_length to match the taggit model - updated the form html to extend the base so the styling matched
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 91.44% 89.21% -2.23%
==========================================
Files 9 9
Lines 736 779 +43
Branches 116 142 +26
==========================================
+ Hits 673 695 +22
- Misses 41 62 +21
Partials 22 22 ☔ View full report in Codecov by Sentry. |
|
Just noticed this one doesn't have a test, will add one tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pertains to this issue #899
Updates:
CHANGELOG.rstdocs/admin.rsttaggit/admin.pytaggit/forms.pytaggit/templates/admin/taggit/merge_tags_form.htmlDemo
https://www.loom.com/share/72db6fb95c7b4b4dab90746d6ad2fd32?sid=dbda0b6a-ee58-4f93-b2bd-67f677a554e9