Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAF: ThrottledAction: improve performance #68

Merged
merged 1 commit into from
Jan 6, 2025
Merged

WAF: ThrottledAction: improve performance #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 18 additions & 27 deletions src/System.Waf/System.Waf/System.Waf.Core/Foundation/ThrottledAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ public enum ThrottledActionMode
public class ThrottledAction
{
private readonly TaskScheduler taskScheduler;
private readonly object cancellationTokenSourceLock = new object();
private readonly Action action;
private readonly ThrottledActionMode mode;
private readonly TimeSpan delayTime;
Expand All @@ -44,50 +43,42 @@ public ThrottledAction(Action action)
/// <exception cref="ArgumentNullException">The argument action must not be null.</exception>
public ThrottledAction(Action action, ThrottledActionMode mode, TimeSpan delayTime)
{
taskScheduler = SynchronizationContext.Current != null ? TaskScheduler.FromCurrentSynchronizationContext() : TaskScheduler.Default;
taskScheduler = SynchronizationContext.Current is not null ? TaskScheduler.FromCurrentSynchronizationContext() : TaskScheduler.Default;
this.action = action ?? throw new ArgumentNullException(nameof(action));
this.mode = mode;
this.delayTime = delayTime;
}

/// <summary>Indicates that an execution of the action delegate is requested.</summary>
public bool IsRunning => cancellationTokenSource != null;
public bool IsRunning => cancellationTokenSource is not null;

/// <summary>Requests the execution of the action delegate.</summary>
public void InvokeAccumulated()
{
CancellationToken? token = null;
lock (cancellationTokenSourceLock)
{
if (mode == ThrottledActionMode.InvokeOnlyIfIdleForDelayTime || cancellationTokenSource == null)
{
cancellationTokenSource?.Cancel();
cancellationTokenSource = new CancellationTokenSource();
token = cancellationTokenSource.Token;
}
}
if (mode is not ThrottledActionMode.InvokeOnlyIfIdleForDelayTime && cancellationTokenSource is not null) return;

if (token != null)
var cts = new CancellationTokenSource();
if (mode is ThrottledActionMode.InvokeOnlyIfIdleForDelayTime)
{
Interlocked.Exchange(ref cancellationTokenSource, cts)?.Cancel();
}
else // mode is InvokeMaxEveryDelayTime
{
Task.Delay(delayTime, token.Value).ContinueWith(t =>
{
lock (cancellationTokenSourceLock)
{
cancellationTokenSource = null;
}
TaskHelper.Run(action, taskScheduler);
}, CancellationToken.None, TaskContinuationOptions.ExecuteSynchronously | TaskContinuationOptions.OnlyOnRanToCompletion, TaskScheduler.Default);
var old = Interlocked.CompareExchange(ref cancellationTokenSource, cts, null);
if (old is not null) return;
}

Task.Delay(delayTime, cts.Token).ContinueWith(t =>
{
Interlocked.Exchange(ref cancellationTokenSource, null);
TaskHelper.Run(action, taskScheduler);
}, CancellationToken.None, TaskContinuationOptions.ExecuteSynchronously | TaskContinuationOptions.OnlyOnRanToCompletion, TaskScheduler.Default);
}

/// <summary>Cancel the execution of the action delegate that was requested.</summary>
public void Cancel()
{
lock (cancellationTokenSourceLock)
{
cancellationTokenSource?.Cancel();
cancellationTokenSource = null;
}
Interlocked.Exchange(ref cancellationTokenSource, null)?.Cancel();
}
}
}