move updateAndGet last to establish happens-before for the actual encode

jbellis · Jan 9, 2025 · 9143fd3 · 9143fd3
1 parent 72044bf
commit 9143fd3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/jvector-base/src/main/java/io/github/jbellis/jvector/quantization/MutablePQVectors.java b/jvector-base/src/main/java/io/github/jbellis/jvector/quantization/MutablePQVectors.java
@@ -48,15 +48,15 @@ public MutablePQVectors(ProductQuantization pq) {
     @Override
     public void encodeAndSet(int ordinal, VectorFloat<?> vector) {
         ensureChunkCapacity(ordinal);
-        vectorCount.updateAndGet(current -> max(current, ordinal + 1));
         pq.encodeTo(vector, get(ordinal));
+        vectorCount.updateAndGet(current -> max(current, ordinal + 1));
     }
 
     @Override
     public void setZero(int ordinal) {
         ensureChunkCapacity(ordinal);
-        vectorCount.updateAndGet(current -> max(current, ordinal + 1));
         get(ordinal).zero();
+        vectorCount.updateAndGet(current -> max(current, ordinal + 1));
     }
 
     private void ensureChunkCapacity(int ordinal) {