Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fma in SIMD Euclidean/cosine #153

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Use fma in SIMD Euclidean/cosine #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions jvector-twenty/src/main/java/io/github/jbellis/jvector/vector/SimdOps.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,8 @@ static float cosineSimilarity(float[] v1, float[] v2) {
var a = FloatVector.fromArray(FloatVector.SPECIES_PREFERRED, v1, i);
var b = FloatVector.fromArray(FloatVector.SPECIES_PREFERRED, v2, i);
vsum = a.fma(b, vsum);
vaMagnitude = vaMagnitude.add(a.mul(a));
vbMagnitude = vbMagnitude.add(b.mul(b));
vaMagnitude = a.fma(a, vaMagnitude);
vbMagnitude = b.fma(b, vbMagnitude);
}

float sum = vsum.reduceLanes(VectorOperators.ADD);
Expand Down Expand Up @@ -379,7 +379,7 @@ static float squareDistance64(float[] v1, int v1offset, float[] v2, int v2offset
FloatVector a = FloatVector.fromArray(FloatVector.SPECIES_64, v1, v1offset + i);
FloatVector b = FloatVector.fromArray(FloatVector.SPECIES_64, v2, v2offset + i);
var diff = a.sub(b);
sum = sum.add(diff.mul(diff));
sum = diff.fma(diff, sum);
}

float res = sum.reduceLanes(VectorOperators.ADD);
Expand All @@ -406,7 +406,7 @@ static float squareDistance128(float[] v1, int v1offset, float[] v2, int v2offse
FloatVector a = FloatVector.fromArray(FloatVector.SPECIES_128, v1, v1offset + i);
FloatVector b = FloatVector.fromArray(FloatVector.SPECIES_128, v2, v2offset + i);
var diff = a.sub(b);
sum = sum.add(diff.mul(diff));
sum = diff.fma(diff, sum);
}

float res = sum.reduceLanes(VectorOperators.ADD);
Expand Down Expand Up @@ -434,7 +434,7 @@ static float squareDistance256(float[] v1, int v1offset, float[] v2, int v2offse
FloatVector a = FloatVector.fromArray(FloatVector.SPECIES_256, v1, v1offset + i);
FloatVector b = FloatVector.fromArray(FloatVector.SPECIES_256, v2, v2offset + i);
var diff = a.sub(b);
sum = sum.add(diff.mul(diff));
sum = diff.fma(diff, sum);
}

float res = sum.reduceLanes(VectorOperators.ADD);
Expand Down Expand Up @@ -462,7 +462,7 @@ static float squareDistancePreferred(float[] v1, int v1offset, float[] v2, int v
FloatVector a = FloatVector.fromArray(FloatVector.SPECIES_PREFERRED, v1, v1offset + i);
FloatVector b = FloatVector.fromArray(FloatVector.SPECIES_PREFERRED, v2, v2offset + i);
var diff = a.sub(b);
sum = sum.add(diff.mul(diff));
sum = diff.fma(diff, sum);
}

float res = sum.reduceLanes(VectorOperators.ADD);
Expand Down