Add cli-option to the serve sub-command to allow different time format #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed: First changes, Add TimeFormat Enum, impls, and basic logic Fix formatting bug with seconds Fix empty string with no timer Restructure format minutes and seconds, fix bug Fix zero second bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the [TIME_FORMAT] options to the
servesub command that allows for different formats of time returned from the script.It takes an optional argument, which can be either
m,s, orm:swhich formats the time as, minutes (same as original), seconds, or a string "MM:SS".This has no effect on the original behavior unless that option is specified.
I know this changes was mentioned in #3, where it was said that this kind of feature wasn't planned, and as such I understand if this PR is unwelcome, and I apologize.
If there is anything I need to change let me know, and thank you for your time, and an amazing project! :)