Skip to content

Commit

Permalink
Update ENV instructions
Browse files Browse the repository at this point in the history
Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
  • Loading branch information
jmesnil committed Sep 26, 2024
1 parent c5233c0 commit 0c6b604
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build and push WildFly Docker images
name: Build WildFly Docker images

# This action requires 4 secrets:
# secrets.REGISTRY - the container registry (e.g. quay.io)
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ RUN groupadd -r jboss -g 1000 && useradd -u 1000 -r -g jboss -m -d /opt/jboss -s
chmod 755 /opt/jboss

# Set the WILDFLY_VERSION env variable
ENV WILDFLY_VERSION 33.0.2.Final
ENV WILDFLY_SHA1 a42e8cb6a83931a8f85c7064cb7220e16c6dc0c9
ENV JBOSS_HOME /opt/jboss/wildfly
ENV WILDFLY_VERSION=33.0.2.Final
ENV WILDFLY_SHA1=a42e8cb6a83931a8f85c7064cb7220e16c6dc0c9
ENV JBOSS_HOME=/opt/jboss/wildfly

USER root

Expand All @@ -35,7 +35,7 @@ RUN cd $HOME \
&& chmod -R g+rw ${JBOSS_HOME}

# Ensure signals are forwarded to the JVM process correctly for graceful shutdown
ENV LAUNCH_JBOSS_IN_BACKGROUND true
ENV LAUNCH_JBOSS_IN_BACKGROUND=true

USER jboss

Expand Down
3 changes: 2 additions & 1 deletion scripts/smoke-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ check_wildfly_version() {
return 1
}

WILDFLY_VERSION=$(grep "ENV WILDFLY_VERSION" Dockerfile | rev | cut -d' ' -f1 | rev)
# Get the WildFly version by cutting "ENV WILDFLY_VERSION="
WILDFLY_VERSION=$(grep "ENV WILDFLY_VERSION=" Dockerfile | cut -c21-)

docker run --rm -p 8080:8080 ${WILDFLY_IMAGE} &
sleep 2
Expand Down

0 comments on commit 0c6b604

Please sign in to comment.