Update ENV instructions

Signed-off-by: Jeff Mesnil <jmesnil@redhat.com>
jboss-dockerfiles · Sep 26, 2024 · 11ab5d0 · 11ab5d0
1 parent 8ac1300
commit 11ab5d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -17,9 +17,9 @@ RUN groupadd -r jboss -g 1000 && useradd -u 1000 -r -g jboss -m -d /opt/jboss -s
     chmod 755 /opt/jboss
 
 # Set the WILDFLY_VERSION env variable
-ENV WILDFLY_VERSION 33.0.2.Final
-ENV WILDFLY_SHA1 a42e8cb6a83931a8f85c7064cb7220e16c6dc0c9
-ENV JBOSS_HOME /opt/jboss/wildfly
+ENV WILDFLY_VERSION=33.0.2.Final
+ENV WILDFLY_SHA1=a42e8cb6a83931a8f85c7064cb7220e16c6dc0c9
+ENV JBOSS_HOME=/opt/jboss/wildfly
 
 USER root
 
@@ -35,7 +35,7 @@ RUN cd $HOME \
     && chmod -R g+rw ${JBOSS_HOME}
 
 # Ensure signals are forwarded to the JVM process correctly for graceful shutdown
-ENV LAUNCH_JBOSS_IN_BACKGROUND true
+ENV LAUNCH_JBOSS_IN_BACKGROUND=true
 
 USER jboss
 

diff --git a/scripts/smoke-test.sh b/scripts/smoke-test.sh
@@ -40,7 +40,8 @@ check_wildfly_version() {
   return 1
 }
 
-WILDFLY_VERSION=$(grep "ENV WILDFLY_VERSION" Dockerfile | rev | cut -d' ' -f1 | rev)
+# Get the WildFly version by cutting "ENV WILDFLY_VERSION="
+WILDFLY_VERSION=$(grep "ENV WILDFLY_VERSION=" Dockerfile | cut -c21-)
 
 docker run --rm -p 8080:8080 ${WILDFLY_IMAGE} &
 sleep 2