Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ENV instructions #218

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build and push WildFly Docker images
name: Build WildFly Docker images

# This action requires 4 secrets:
# secrets.REGISTRY - the container registry (e.g. quay.io)
Expand Down
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ RUN groupadd -r jboss -g 1000 && useradd -u 1000 -r -g jboss -m -d /opt/jboss -s
chmod 755 /opt/jboss

# Set the WILDFLY_VERSION env variable
ENV WILDFLY_VERSION 33.0.2.Final
ENV WILDFLY_SHA1 a42e8cb6a83931a8f85c7064cb7220e16c6dc0c9
ENV JBOSS_HOME /opt/jboss/wildfly
ENV WILDFLY_VERSION=33.0.2.Final
ENV WILDFLY_SHA1=a42e8cb6a83931a8f85c7064cb7220e16c6dc0c9
ENV JBOSS_HOME=/opt/jboss/wildfly

USER root

Expand All @@ -35,7 +35,7 @@ RUN cd $HOME \
&& chmod -R g+rw ${JBOSS_HOME}

# Ensure signals are forwarded to the JVM process correctly for graceful shutdown
ENV LAUNCH_JBOSS_IN_BACKGROUND true
ENV LAUNCH_JBOSS_IN_BACKGROUND=true

USER jboss

Expand Down
3 changes: 2 additions & 1 deletion scripts/smoke-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ check_wildfly_version() {
return 1
}

WILDFLY_VERSION=$(grep "ENV WILDFLY_VERSION" Dockerfile | rev | cut -d' ' -f1 | rev)
# Get the WildFly version by cutting "ENV WILDFLY_VERSION="
WILDFLY_VERSION=$(grep "ENV WILDFLY_VERSION=" Dockerfile | cut -c21-)

docker run --rm -p 8080:8080 ${WILDFLY_IMAGE} &
sleep 2
Expand Down
Loading