Added the ability to specify a Narayana repo and abranch#193
Added the ability to specify a Narayana repo and abranch#193tomjenkinson wants to merge 1 commit intomainfrom
Conversation
tomjenkinson
force-pushed
the
tomjenkinson-patch-6
branch
from
bcf3e69 to
d08f643
Compare
jmfinelli
force-pushed
the
tomjenkinson-patch-6
branch
from
2530d0e to
e7dc744
Compare
|
Thank you @jmfinelli for the great improvement you added on top of the base change. I am not sure if we can review each other or not but I am going to add my review and I will request one from you too. But I will put @marcosgopen and @mmusgrov as well and if either of those approve (or maybe one of us) I'll merge it. |
tomjenkinson
left a comment
tomjenkinson
left a comment
There was a problem hiding this comment.
I can't add an approval on this repo, but I would approve!
That being said, I am not sure I would intend to keep both run_bm and jenkins over time but we can tackle that later. @jmfinelli - you swapped to jenkins rather than run_bm.sh, I guess there is a reason and I don't object. I don't know why it seems I put run_bm.sh in the first place but that and jenkins.sh look rather similar
| fi | ||
| OVERRIDE_NARAYANA_VERSION=`grep "<version>" narayana-tmp/pom.xml | head -n 2 | tail -n 1 | sed "s/ *<version>//" | sed "s#</version>##"` | ||
| echo "Checking if need Narayana PR" | ||
| if [ -n "$NY_BRANCH" ]; then |
There was a problem hiding this comment.
Not sure what is NY_BRANCH about...?
There was a problem hiding this comment.
It looks like NY_BRANCH is used to checkout PRs. No sure who introduced it and for what reason though
There was a problem hiding this comment.
I think it was me a long time ago.
"Nara" "yana" is maybe where I was going with the lettering... maybe it should have been NRYN
Nice to read that you don't want to keep both scripts. I was planning to ask the same question in the PR. Let's keep just |
jmfinelli
force-pushed
the
tomjenkinson-patch-6
branch
2 times, most recently
from
5b61534 to
1a9f51f
Compare
|
Am I wrong or we need to build WildFly as well? |
| @@ -101,7 +145,18 @@ jobs: | |||
| core.setOutput('jdk_versions', JSON.stringify(jdk_versions)); | |||
|
|
|||
| const possibleEnvVars = [ | |||
There was a problem hiding this comment.
Look like a comprehensive set of config variables, nice.
jmfinelli
force-pushed
the
tomjenkinson-patch-6
branch
3 times, most recently
from
3fc37dd to
7850c33
Compare
jmfinelli
force-pushed
the
tomjenkinson-patch-6
branch
from
7850c33 to
517ad1b
Compare
|
I further modified this PR to download WildFly but I don't think I will have time to test it thoroughly before my PTO. Please, feel free to take it over and complete the modification. |
Thank you! |
4 participants
NARAYANA_REPO=mmusgrov
NARAYANA_BRANCH=JBTM-845