Skip to content

Fix display text is None if display_code or fault_code is 0 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix display text is None if display_code or fault_code is 0 #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions incomfortclient/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,8 @@ def status(self) -> dict[str, Any]:
def display_text(self) -> str | None:
"""Return the display or fault code as text label rather than a code."""
if self.is_failed:
return self.fault_code.name.lower() if self.fault_code else None
return self.display_code.name.lower() if self.display_code else None
return self.fault_code.name.lower() if self.fault_code is not None else None
return self.display_code.name.lower() if self.display_code is not None else None

@property
def is_burning(self) -> bool:
Expand Down
Loading