Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated fork #25

Open
ealeksandrov opened this issue Oct 12, 2016 · 9 comments
Open

Updated fork #25

ealeksandrov opened this issue Oct 12, 2016 · 9 comments
Labels
alternatives Alternatives/Forks ofthis version of cd to

Comments

@ealeksandrov
Copy link

Hey, everyone interested in this project.
Since author don't have time to update this repository and in pull requests I see a lot of valuable contributions - I created a fork and merged most important PRs there (#13, #14, #21, #22), cleaned up code a bit and released latest code-signed binary. Tested on macOS 10.12 Sierra and iTerm2 3.0.10.

Welcome:
https://github.com/ealeksandrov/cdto

@jbtule thanks for your project, it is pretty awesome, feel free to merge/cherry-pick some of my commits if you'll decide to update your upstream.

@tghs
Copy link
Contributor

tghs commented Oct 12, 2016

@ealeksandrov Thanks for doing this. 👍

adidalal pushed a commit to Homebrew/homebrew-cask that referenced this issue Nov 21, 2016
* Add ealeksandrov-cd-to 2.7 (fork of cd-to)

The original project isn't being updated anymore. This fork is discussed
here: jbtule/cdto#25. The old maintainer has
acknowledged it and not raised any objections to the fork.

* Update ealeksandrov-cd-to.rb
@dimitrieh
Copy link

@ealeksandrov thanks for doing this! getting your fork in my brewfile as cask ! awesome stuff

@tghs
Copy link
Contributor

tghs commented Dec 17, 2016

On the cask situation, I've added the fork as the ealeksandrov-cd-to cask as per their policy on packaging forks.

The cd-to cask can be updated to the fork if @jbtule nominates the fork as a successor (e.g. by linking to it in the README.md file).

@dimitrieh
Copy link

@ealeksandrov would you be able to write a plugin to use it with https://github.com/zeit/hyper ? :)

@ealeksandrov
Copy link
Author

@dimitrieh don't have time yet, but look into https://github.com/ealeksandrov/cdto/blob/master/plugins/iterm/CD2ITerm.m#L16 - try to change this to hyper bundle id.
Feel free to submit PR :)

@dimitrieh
Copy link

@ealeksandrov see ealeksandrov#1

@dreambottle
Copy link

dreambottle commented Feb 6, 2017

@ealeksandrov I don't see the "Issues" tab in your fork. Why don't you open it up :)

P.S. Kudos for a macos-style icon

@dimitrieh
Copy link

@ealeksandrov and could you adjust the cask recipes to preselect which version of cd_to you want to use? :) (say hyper in my case)

@ealeksandrov
Copy link
Author

@dreambottle sure, I don't know why it disappeared. It's there now :)
@dimitrieh I haven't touched that casks out there. I think @tghs added them. Let's continue discussing it in ealeksandrov#2

Repository owner deleted a comment from onmyway133 Nov 8, 2017
@jbtule jbtule added the alternatives Alternatives/Forks ofthis version of cd to label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alternatives Alternatives/Forks ofthis version of cd to
Projects
None yet
Development

No branches or pull requests

5 participants