Upd: Show placeholder image by playlist type

jcorporation · Sep 15, 2024 · b4774cd · b4774cd
1 parent 8bf9789
commit b4774cd
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 4 deletions.
diff --git a/docs/references/webserver-uris.md b/docs/references/webserver-uris.md
@@ -17,7 +17,7 @@ Reference of all webserver uris.
 | `/browse/` | Prints the list of [published directories]({{ site.baseurl }}/references/published-directories) |
 | `/ca.crt` | Returns the myMPD CA certificate |
 | `/folderart?path=<path>` | Returns the folderart thumbnail. |
-| `/playlistart?playlist=<playlist name>` | Returns the playlistart thumbnail. |
+| `/playlistart?type=<plist,smartpls>&playlist=<playlist name>` | Returns the playlistart thumbnail or a redirect to the placeholder image if not found. |
 | `/proxy?uri=<uri>` | Fetches the response from the uri (GET), allowed hosts: `jcorporation.github.io`, `musicbrainz.org`, `listenbrainz.org` |
 | `/script/<partition>/<script>` | Executes a script (Script should return a valid http response) |
 | `/script-api/<partition>` | Jsonrpc api endpoint for mympd-script |

diff --git a/htdocs/js/viewBrowsePlaylist.js b/htdocs/js/viewBrowsePlaylist.js
@@ -190,7 +190,8 @@ function parsePlaylistDetail(obj) {
 
     if (obj.result.pics === true) {
         const img = elCreateEmpty('div', {});
-        img.style.backgroundImage = getCssImageUri('/playlistart?playlist=' + myEncodeURIComponent(obj.result.plist));
+        img.style.backgroundImage = getCssImageUri('/playlistart?type=' +
+            (obj.result.smartpls === false ? 'plist' : 'smartpls') + '&playlist=' + myEncodeURIComponent(obj.result.plist));
         img.addEventListener('click', function(event) {
             zoomPicture(event.target);
         }, false);

diff --git a/htdocs/js/views.js b/htdocs/js/views.js
@@ -702,7 +702,7 @@ function setEntryData(entry, data) {
             break;
         case 'plist':
         case 'smartpls':
-            data.Thumbnail = getCssImageUri('/playlistart?playlist=' + myEncodeURIComponent(data.uri));
+            data.Thumbnail = getCssImageUri('/playlistart?type=' + data.Type + '&playlist=' + myEncodeURIComponent(data.uri));
             break;
         case 'webradiodb':
             data.Thumbnail = getCssImageUri(data.Image);

diff --git a/src/web_server/playlistart.c b/src/web_server/playlistart.c
@@ -30,14 +30,18 @@ bool request_handler_playlistart(struct mg_connection *nc, struct mg_http_messag
 {
     struct t_config *config = mg_user_data->config;
     sds name = get_uri_param(&hm->query, "playlist=");
+    sds type = get_uri_param(&hm->query, "type=");
 
     if (name == NULL ||
+        type == NULL ||
         sdslen(name) == 0 ||
+        sdslen(type) == 0 ||
         vcb_isfilepath(name) == false)
     {
         MYMPD_LOG_ERROR(NULL, "Failed to decode query");
         webserver_redirect_placeholder_image(nc, PLACEHOLDER_PLAYLIST);
         FREE_SDS(name);
+        FREE_SDS(type);
         return false;
     }
     strip_file_extension(name);
@@ -53,9 +57,15 @@ bool request_handler_playlistart(struct mg_connection *nc, struct mg_http_messag
     }
     else {
         MYMPD_LOG_DEBUG(NULL, "No image for playlist found");
-        webserver_redirect_placeholder_image(nc, PLACEHOLDER_PLAYLIST);
+        if (strcmp(type, "smartpls") == 0) {
+            webserver_redirect_placeholder_image(nc, PLACEHOLDER_SMARTPLS);
+        }
+        else {
+            webserver_redirect_placeholder_image(nc, PLACEHOLDER_PLAYLIST);
+        }
     }
     FREE_SDS(mediafile);
     FREE_SDS(name);
+    FREE_SDS(type);
     return true;
 }