Skip to content

Commit

Permalink
Fix: ignore toggle type upgrades
Browse files Browse the repository at this point in the history
  • Loading branch information
jcppkkk committed Sep 19, 2021
1 parent dbc3ffc commit 99a07ce
Showing 4 changed files with 16 additions and 17 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [2042.10] - 2021-09-19
### Fixed
- Ignore toggle type upgrades

## [2042.9] - 2021-09-18
### Changed
- Suppress notation on 0% upgrades.
11 changes: 2 additions & 9 deletions RELEASE.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
## [2042.9] - 2021-09-18
### Changed
- Suppress notation on 0% upgrades.
- Avoid sorting upgrades in toggle pool.

## [2042.10] - 2021-09-19
### Fixed
- Fix errors afters ascend.
- Fix that best deals do not show in blue if multiple deals have same ratio.
- Fix errors with Mile Selector.
- Fix 0% rate updates are included in normalizing process.
- Ignore toggle type upgrades
4 changes: 2 additions & 2 deletions info.txt
Original file line number Diff line number Diff line change
@@ -3,9 +3,9 @@
"ID": "Best Deal Helper",
"Author": "Jethro Yu",
"Description": "Help you choose best deal!",
"ModVersion": 2042.8,
"ModVersion": 2042.10,
"GameVersion": 2.042,
"Date": "18/09/2021",
"Date": "19/09/2021",
"Dependencies": ["CCSE"],
"Disabled": 1,
"AllowSteamAchievs": 1
14 changes: 8 additions & 6 deletions main.js
Original file line number Diff line number Diff line change
@@ -120,15 +120,15 @@ let BestDealHelper = {

logicLoop: function () {
MOD.loopCount++;
if (MOD.loopCount >= 10
if (MOD.loopCount >= 20
|| MOD.last_cps !== Game.cookiesPs
|| MOD.config.sortbuildings !== MOD.last_config_sortbuildings
|| !document.querySelector("#productAcc0")
|| (document.querySelector("#upgrade0") && !document.querySelector("#upgradeAcc0"))) {
MOD.sortDeals();
MOD.loopCount = 0;
MOD.last_config_sortbuildings = MOD.config.sortbuildings;
MOD.last_cps = Game.cookiesPs;
MOD.loopCount = 0;
}
},

@@ -138,9 +138,11 @@ let BestDealHelper = {

getCpsAcceleration: function (me) {
// Treat Grandmapocalypse upgrade as 0% temporary
if (["One mind", "Communal brainsweep", "Elder pact"].includes(me.name)) return 0;
if (Game.cookies === 0) return 0;

if (["One mind", "Communal brainsweep", "Elder pact"].includes(me.name)
|| me.pool === "toggle"
|| Game.cookies === 0) {
return 0;
}

// Backup
Game.Logic_ = Game.Logic;
@@ -318,7 +320,7 @@ let BestDealHelper = {
if (!upgrades_order.every((value, index) => value === current_upgrades_order[index])) {
let store = document.querySelector("#upgrades");
for (let i = 0; i < upgrades.length; ++i) {
if(upgrades[i].pool === "toggle") continue;
if (upgrades[i].pool === "toggle") continue;
store.appendChild(upgrades[i].l);
}
}

0 comments on commit 99a07ce

Please sign in to comment.