Allow referring to current module version using _#43
Open
jaor wants to merge 2 commits intojcrossley3:masterfrom
Open
Allow referring to current module version using _#43jaor wants to merge 2 commits intojcrossley3:masterfrom
jaor wants to merge 2 commits intojcrossley3:masterfrom
Conversation
Sometimes in projects you want the internal dependencies of a module to always refer to the current version of that module. Having to edit :versions in the parent every time a submodule version changes is a solution, but one can forget to do so and also it's a bit against the idea of self-discovery. This little patch makes available the versions of all modules to versionize, so that one can write ```clojure ["module-a" "_"] ``` as a dep in "module-b" to refer to the current version of "module-a" in the project, without having to list "module-a" explictly in :versions. The patch is ugly in that it uses mutation to hook into `versionize`, but modifying the actual versions maps in the project object in a way that it's seen in substasks doesn't seem possible without touching the project.clj.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes in projects you want the internal dependencies of a module
to always refer to the current version of that module. Having to edit
:versions in the parent every time a submodule version changes is a
solution, but one can forget to do so and also it's a bit against the
idea of self-discovery. This little patch makes available the
versions of all modules to versionize, so that one can write
as a dep in "module-b" to refer to the current version of "module-a"
in the project, without having to list "module-a" explictly in
:versions.
The patch is ugly in that it uses mutation to hook into
versionize,but modifying the actual versions maps in the project object in a way
that it's seen in substasks doesn't seem possible without touching the
project.clj. Just a suggestion more than a fully fledged PR.