Added keepWords option and fixed unresponsive config function #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcubic
reviewed
Jul 5, 2022
| if (typeof name === 'object') { | ||
| for (const [key, value] of Object.entries(name)) { | ||
| this._config[key] = value | ||
| } |
There was a problem hiding this comment.
You removed old behavior and you've deleted completion option. Now all options will stop working since you only set this._config and ignore terminal settings.
|
This PR is invalid, it has a lot of errors, and you didn't respond to my CR. So I'm closing this. Feel free to fix the issue and create proper PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configas described in the documentation was not successfully setting the configurable options. I'm not sure if this is the intended behavior, but I fixed it for my use.Additionally
keepWordsis now passed along by bothechofunctions, but it is set tofalseas the default. This should address #77.