perf: input

[oasis-cloud]

🤔 这个变动的性质是？

• 新特性提交
• 日常 bug 修复
• 站点、文档改进
• 演示代码改进
• 组件样式/交互改进
• TypeScript 定义更新
• 包体积优化
• 性能优化
• 功能增强
• 国际化改进
• 重构
• 代码风格优化
• 测试用例
• 分支合并
• 其他改动（是关于什么的改动？）

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

• 文档已补充或无须补充
• 代码演示已提供或无须提供
• TypeScript 定义已补充或无须补充
• fork仓库代码是否为最新避免文件冲突
• Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

• 重构

  • 优化了输入组件的事件处理和交互逻辑，提升了系统响应的一致性与稳定性。
  • 更新了输入组件的属性类型定义，增强了代码的清晰度。

• 样式更新

  • 更新了文本对齐逻辑，使输入内容在不同布局下显示更加清晰和协调。

[coderabbitai]

Walkthrough

本次 PR 修改了两个 Input 组件文件。在 src/packages/input/input.taro.tsx 中，添加了 BaseEventOrig 导入，简化了 updateValue 函数逻辑，并调整了 handleInput 事件处理方式，同时将内联样式替换为调用 getTextAlign 函数。在 src/packages/input/input.tsx 中，对导入顺序进行整理，更新了事件及接口类型，重命名并简化了多个函数（如 updateValue → handleValueUpdate、inputClass → getInputClass、inputType → getInputType、handleInput → handleInputChange），并优化了 useImperativeHandle 的实现和清除图标的渲染逻辑。

Changes

文件	变更概要
src/packages/input/input.taro.tsx	- 添加 BaseEventOrig 导入 - 简化 updateValue 函数逻辑，直接调用 eventHandler - 修改 handleInput 接收 BaseEventOrig，提取事件值 - 使用 getTextAlign 函数计算样式
src/packages/input/input.tsx	- 重新排序并补充导入（MouseEvent、useRef） - 更新 InputProps 接口（formatter 返回类型、onClick 参数类型） - 重命名并简化函数逻辑（如 updateValue、inputClass、inputType、handleInput） - 简化 useImperativeHandle 和清除图标渲染 - 添加 getTextAlign 函数

Sequence Diagram(s)

sequenceDiagram
    participant U as 用户
    participant IC as Input组件
    participant EH as 事件处理器
    U->>IC: 触发输入事件
    IC->>IC: 提取事件值 (detail/currentTarget)
    alt 非 onChange 触发
        IC->>EH: 调用事件处理器 (eventHandler?.(val))
    end
    EH-->>IC: 返回处理结果
    IC->>IC: 更新组件状态

Loading

Possibly related PRs

• feat(input): update icon #2711: 此 PR 与主 PR 相关，因为两者都涉及对 updateValue 函数的修改，尽管名称不同（主 PR 中为 updateValue，而检索到的 PR 中为 handleValueUpdate）。
• feat(input): 适配鸿蒙、小程序、H5、RN; 鸿蒙下无法隐藏密码Icon #2338: 此 PR 直接修改了 updateValue 函数，已重命名为 handleValueUpdate，与本次 PR 存在较强的代码层面联系。

Suggested reviewers

• Alex-huxiyang

Poem

嗨，我是一只跳跃的小兔子，
见证代码轻盈的转变，
输入组件焕然一新，
函数名字舞动新节拍，
事件流畅如春风拂面 🐇🌸!
代码的花园中，我快乐徜徉。

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 94.82759% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.82%. Comparing base (e7eb6f1) to head (cfb200a).
Report is 1 commits behind head on feat_v3.x.

Files with missing lines	Patch %	Lines
src/packages/input/input.tsx	94.82%	3 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           feat_v3.x    #2978      +/-   ##
=============================================
+ Coverage      85.79%   85.82%   +0.02%     
=============================================
  Files            281      281              
  Lines          18527    18491      -36     
  Branches        2810     2803       -7     
=============================================
- Hits           15896    15869      -27     
+ Misses          2626     2617       -9     
  Partials           5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test

test

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/packages/input/input.tsx (1)

176-182: RTL 支持实现不错，建议补充测试

getTextAlign 函数很好地处理了 RTL 场景，但建议：

1. 添加单元测试验证 RTL 逻辑
2. 考虑添加 RTL 相关的文档说明

需要我帮助编写 RTL 相关的测试用例吗？

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de41f1d and cfb200a.

📒 Files selected for processing (2)

• src/packages/input/input.taro.tsx (5 hunks)
• src/packages/input/input.tsx (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/packages/input/input.taro.tsx

🧰 Additional context used

🪛 GitHub Check: codecov/patch

src/packages/input/input.tsx

[warning] 119-120: src/packages/input/input.tsx#L119-L120
Added lines #L119 - L120 were not covered by tests

---

[warning] 224-224: src/packages/input/input.tsx#L224
Added line #L224 was not covered by tests

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: build
• GitHub Check: lint
• GitHub Check: test

🔇 Additional comments (4)

src/packages/input/input.tsx (4)

3-7: 导入更改增强了类型安全性！

新增的导入优化了类型定义并添加了必要的 hooks，使代码更加健壮。

---

37-42: 类型定义改进提高了 API 的精确性！

• formatter 函数现在明确返回 string 类型
• onClick 事件参数重命名为更标准的 event

---

114-121: 建议增加测试覆盖率

useImperativeHandle 的实现更加简洁，但是缺少测试覆盖。建议添加以下测试场景：

• clear 方法的调用
• focus/blur 方法的行为
• nativeElement 的访问

我可以帮助编写相关的单元测试用例，是否需要我提供测试代码？

🧰 Tools

🪛 GitHub Check: codecov/patch

[warning] 119-120: src/packages/input/input.tsx#L119-L120
Added lines #L119 - L120 were not covered by tests

---

135-168: 事件处理逻辑优化得很好！

• 函数命名更加清晰（如 handleValueUpdate）
• 值更新逻辑更加统一
• 事件处理更加一致