Skip to content

Conversation

@anna-belemenko17
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Code formatting

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@anna-belemenko17 anna-belemenko17 requested a review from v3rde May 26, 2020 11:26
@T0mJones
Copy link

T0mJones commented Jun 5, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- JDI.Light/JDI.BDD/StepDefs/CheckBoxSteps.cs  1
- JDI.Light/JDI.BDD/StepDefs/JDISteps.cs  1
         

See the complete overview on Codacy

Copy link
Contributor

@pnatashap pnatashap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we need several tests for BDD

@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="BoDi" version="1.4.1" targetFramework="net472" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be it's better to use one .net version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants