fix(mode): bugs detected during testing

jdomingu98 · May 8, 2024 · f8fcf5e · f8fcf5e
1 parent 1a66f4c
commit f8fcf5e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/Channel.cpp b/src/Channel.cpp
@@ -348,10 +348,10 @@ void Channel::removeUser(const std::string &nickname) {
  */
 void Channel::makeUserAnOper(std::string nickname) {
     std::vector<User *>::iterator it = findUser(nickname);
-    if (it == this->_users.end())
-        throw UserNotInChannelException(nickname, this->_name);
-    this->_operators.push_back(*it);
-    this->_users.erase(it);
+    if (it != this->_users.end()) {
+        this->_operators.push_back(*it);
+        this->_users.erase(it);
+    }
 }
 
 /**
@@ -363,10 +363,10 @@ void Channel::makeUserAnOper(std::string nickname) {
  */
 void Channel::makeOperAnUser(std::string nickname) {
     std::vector<User *>::iterator it = findOper(nickname);
-    if (it == this->_operators.end())
-        throw UserNotInChannelException(nickname, this->_name);
-    this->_users.push_back(*it);
-    this->_operators.erase(it);
+    if (it == this->_operators.end()) {
+        this->_users.push_back(*it);
+        this->_operators.erase(it);
+    }
 }
 
 /**

diff --git a/src/parser/ModeParser.cpp b/src/parser/ModeParser.cpp
@@ -46,5 +46,5 @@ ACommand *ModeParser::parse(const std::vector<std::string>& tokens) {
     for (size_t i = 3; i < tokens.size(); i++)
         modeParams.push_back(tokens[i]);
 
-    return new ModeCommand(modesTok[0] == '+', tokens[1], modes, modeParams);
+    return new ModeCommand(modesTok[0] != '-', tokens[1], modes, modeParams);
 }