Add LFN support to machines/pcx86/modules/v3/diskinfo.js#118
Open
petergeneric wants to merge 1 commit intojeffpar:masterfrom
Open
Add LFN support to machines/pcx86/modules/v3/diskinfo.js#118petergeneric wants to merge 1 commit intojeffpar:masterfrom
petergeneric wants to merge 1 commit intojeffpar:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #99 allowing diskutility.js to write LFN entries instead of truncating filenames.
Basic tests with
tools/diskimage/test-lfn.js(not linked intonpm run testbecause there are no other tests specified and I don't want to make it seem like this is adding more tests...);I've also run tests of the generated disk image against the macOS FAT driver and it looks good to me