Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict mode crashing on arguments assign #252

Merged
merged 1 commit into from
Dec 16, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/plugins/local-llm-rename/visit-all-identifiers.test.ts
Original file line number Diff line number Diff line change
@@ -298,3 +298,20 @@ const bar = 2;
`.trim()
);
});

test("should not craash to 'arguments' assigning", async () => {
const code = `
function foo() {
arguments = '??';
}
`.trim();
const result = await visitAllIdentifiers(code, async () => "foobar", 200);
assert.equal(
result,
`
function foobar() {
arguments = '??';
}
`.trim()
);
});
2 changes: 1 addition & 1 deletion src/plugins/local-llm-rename/visit-all-identifiers.ts
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ export async function visitAllIdentifiers(
contextWindowSize: number,
onProgress?: (percentageDone: number) => void
) {
const ast = await parseAsync(code);
const ast = await parseAsync(code, { sourceType: "script" });
const renames = new Set<string>();
const visited = new Set<string>();