Add button to report device profile to server for troubleshooting #4482
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (maxBitrate == null || maxBitrate < 1) maxBitrate = UserPreferences.maxBitrate.defaultValue.toInt() | ||
|
|
||
| // Convert megabit to bit | ||
| return maxBitrate * 1_000_000 |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning
| private val prettyPrintJson = Json { prettyPrint = true } | ||
| private fun formatJson(json: String) = prettyPrintJson.encodeToString(prettyPrintJson.parseToJsonElement(json)) | ||
|
|
||
| fun createDeviceProfileReport( |
Check warning
Code scanning / detekt
One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand. Warning
| private val prettyPrintJson = Json { prettyPrint = true } | ||
| private fun formatJson(json: String) = prettyPrintJson.encodeToString(prettyPrintJson.parseToJsonElement(json)) | ||
|
|
||
| fun createDeviceProfileReport( |
Check warning
Code scanning / detekt
Prefer splitting up complex methods into smaller, easier to test methods. Warning
nielsvanvelzen
force-pushed
the
report-profile
branch
from
b432989 to
6b94582
Compare
Troubleshooting playback issues is extremely difficult because the app doesn't give much insight into what is happening. Even with logging enabled, it can be difficult to figure out why something transcodes or produces a black screen.
This change should somewhat improve that situation by adding a new troubleshooting feature directly inside of the app. At the very least it will be extremely useful to test improvements to the device profile.
Changes
createDeviceProfilefunction that reads user preferences instead of passing them from the usage sideExample
https://gist.github.com/nielsvanvelzen/cba33b29c1dfc82350735fd5f0190abd
Issues