Fix desktop icon #771
Open
Fix desktop icon #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for helping out and also for the credits. |
13 tasks
bjornfor
suggested changes
Jan 17, 2025
There was a problem hiding this comment.
Although this PR fixes the icon issue for me on NixOS with GNOME (Wayland) desktop, I don't necessarily think it alone is a proper fix. The reason is that my jellyfin-media-player instance uses xwayland, not native wayland!
To check yourself, list all xwayland clients:
$ xlsclients
bf-laptop keepassxc
bf-laptop gsd-xsettings
bf-laptop jellyfinmediaplayer <--- bug!
bf-laptop mutter-x11-frames
So either we fix the packaging so that the app runs with native wayland protocol, or the fix must work for both X11 and Wayland. (Currently I think this PR only works for X11.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix desktop icon. Currently when JMP is docked/favorited and then launched it will spawn a separate icon. Setting the StartupWMClass to jellyfinmediaplayer resolves this.
Credit goes to this user on the forum.
https://forum.jellyfin.org/t-desktop-entry-icon-bug-on-linux-client