Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wizard): fix stepper error on wizard page #2553

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Eeymoo
Copy link
Contributor

@Eeymoo Eeymoo commented Jan 8, 2025

I have modified the stepper in the wizard according to the syntax of Vuetify 3.

@jellyfin-bot
Copy link

jellyfin-bot commented Jan 8, 2025

Cloudflare Pages deployment

Latest commit 815979c
Status ✅ Deployed!
Preview URL https://dca8d30a.jf-vue.pages.dev
Preview alias https://eeymoo-jellyfin-vue-master.jf-vue.pages.dev
Type 🔀 Preview

View build logs

@jellyfin-bot jellyfin-bot added the vue Pull requests that edit or add Vue files label Jan 8, 2025
@Eeymoo
Copy link
Contributor Author

Eeymoo commented Jan 8, 2025

@ferferga I'm sorry, I couldn't find the reason why the Actions did not pass. I'm not sure if it's due to historical reasons or my changes. I only modified the frontend/src/pages/wizard.vue file and the automatically generated frontend/types/global/components.d.ts file.

frontend/src/pages/wizard.vue
frontend/types/global/components.d.ts

Copy link
Member

@ferferga ferferga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eeymoo No worries, we've been slowly fixing sthose type errors since the migration to Vue 3. Most of them are caused by Vuetify.

Thank you very much for your PR! If you're interested in further contributions, it would be great if you can port the rest of the components that were left behind (only skeletron cards are left, if I recall correctly. The boilerplate ones that appeared while content was loading is no longer useful, since the pages are completely mounted now when accessed, but the static ones are for displaying as placeholders when no items are returned by the API).

@ferferga ferferga linked an issue Jan 8, 2025 that may be closed by this pull request
* fix(wizard): fix stepper error on wizard page

* fix/eslint error
Copy link

sonarqubecloud bot commented Jan 8, 2025

@ferferga ferferga merged commit 7abbcda into jellyfin:master Jan 8, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vue Pull requests that edit or add Vue files
Projects
Development

Successfully merging this pull request may close these issues.

Setup wizard error
3 participants