chore: update Promise.reject()(s) across codebase to throw Error("message"), instead of regular string

[jimezesinachi]

Changes
This change removes some code smell in the database. According to this rule (https://sonarcloud.io/organizations/jellyfin/rules?open=javascript%3AS6671&rule_key=javascript%3AS6671) on the project's SonarCloud, any Promise.reject call in the repository that currently returns a string, should be updated to return a throw Error('message'), instead. This PR includes changes to different parts of the codebase with this issue.

Issues

• Fixes https://sonarcloud.io/project/issues?open=AYnuoirgJnGD1tMStw4e&id=jellyfin_jellyfin-web, and other similar ones

[jimezesinachi]

I've made two of these changes so far. I will proceed adding more to this PR once I get a response from a maintainer that this change is still useful. Thank you!

[grafixeyehero]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[jellyfin-bot]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[thornbill]

Hey @jimezesinachi! This looks good! Now that 10.9 is finally out the door it would be good to get these fixed. Thanks!

[jimezesinachi]

Excellent! Do you want to merge in this one no, or should I add a couple other changes for the same rule?

[thornbill]

Let's just add the others here 👍

[jimezesinachi]

Let's just add the others here 👍

Excellent. Will work on this on the weekend 👍🏾

[jimezesinachi]

Updated the branch with master... good to merge now

[jimezesinachi]

Note: from the wording of the rule (here: https://sonarcloud.io/organizations/jellyfin/rules?open=javascript%3AS6671&rule_key=javascript%3AS6671), my understanding is that it specifically applies any reject's in the codebase that are currently being passed just a string (i.e reject("ComponentName error!")). There are currently no other ones that match this interpretation, as the other ones are either already returning error (i.e reject(new Error("ComponentName error!"))), or just rejecting without any value passed (i.e (reject()).

LMK what you think @thornbill @grafixeyehero @tomislav

[grafixeyehero]

Note: from the wording of the rule (here: https://sonarcloud.io/organizations/jellyfin/rules?open=javascript%3AS6671&rule_key=javascript%3AS6671), my understanding is that it specifically applies any reject's in the codebase that are currently being passed just a string (i.e reject("ComponentName error!")). There are currently no other ones that match this interpretation, as the other ones are either already returning error (i.e reject(new Error("ComponentName error!"))), or just rejecting without any value passed (i.e (reject()).

LMK what you think @thornbill @grafixeyehero @tomislav

First, we Thanks for your contribution. To ensure consistency in our error handling, we should refactor the rejections that currently use strings or have no value to use Error objects instead.

[jimezesinachi]

Note: from the wording of the rule (here: https://sonarcloud.io/organizations/jellyfin/rules?open=javascript%3AS6671&rule_key=javascript%3AS6671), my understanding is that it specifically applies any reject's in the codebase that are currently being passed just a string (i.e reject("ComponentName error!")). There are currently no other ones that match this interpretation, as the other ones are either already returning error (i.e reject(new Error("ComponentName error!"))), or just rejecting without any value passed (i.e (reject()).

LMK what you think @thornbill @grafixeyehero @tomislav

First, we Thanks for your contribution. To ensure consistency in our error handling, we should refactor the rejections that currently use strings or have no value to use Error objects instead.

Understood. Just one more thing: for the ones that have no value, we can just pass an Empty error object (i.e reject new Error()), yes?

[grafixeyehero]

You can give it a value based on what action was rejected

[jimezesinachi]

You can give it a value based on what action was rejected

Understood. On it now 👍🏾

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[jellyfin-bot]

Cloudflare Pages deployment

Latest commit	3aaaeef
Status	✅ Deployed!
Preview URL	https://6360c746.jellyfin-web.pages.dev
Type	🔀 Preview

View build logs

[thornbill]

@jimezesinachi do you still plan to correct the other instances of this? Thanks!

[jimezesinachi]

@jimezesinachi do you still plan to correct the other instances of this? Thanks!

Affirmative... I'm still away from work, but this is on my agenda when I get back to work

[jimezesinachi]

Back in today... working on this now

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.6% Duplication on New Code

See analysis details on SonarQube Cloud

[jimezesinachi]

Updates are up and Actions check jobs completed

[jimezesinachi]

@thornbill quick review on this?