Migrate apikeys to React #6390
Migrate apikeys to React #6390
Conversation
Cloudflare Pages deployment
|
|
Updated look with mui: |
viown
force-pushed
the
react-apikeys
branch
2 times, most recently
from
c21b88c to
817b59b
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
src/elements/ButtonElement.tsx
Outdated
There was a problem hiding this comment.
It seems like these changes are no longer necessary?
There was a problem hiding this comment.
You're correct -- but it shouldn't hurt. Especially if we plan to use this component anywhere else.
There was a problem hiding this comment.
I would prefer we wait until/if it is needed.
| }, | ||
|
|
||
| // Enable (delete) row actions | ||
| enableRowActions: true, |
There was a problem hiding this comment.
Let's position the action column at the end of the row:
| enableRowActions: true, | |
| enableRowActions: true, | |
| positionActionsColumn: 'last', |
| }, | ||
|
|
||
| renderTopToolbarCustomActions: () => ( | ||
| <Button onClick={showNewKeyPopup}>{globalize.translate('HeaderNewApiKey')}</Button> |
There was a problem hiding this comment.
Maybe add a "+" icon to the button?
Changes
onClicklistener toButtonElementsimilar to IconButtonElementIssues