Skip to content

cleanup: remove legacy mirrorbits chart and rename mirrorbits-lite to mirrorbits 1/2 #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jan 9, 2024

Ref. jenkins-infra/helpdesk#3828 (comment)

Note that mirrorbits-parent is not updated yet as it require a first release of the "new" mirrorbits chart (2.0.0+)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
…xcept for mirrorbits-parent)

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal changed the title Helpdesk 3828 cleanup: remove legacy mirrorbits chart and rename mirrorbits-lite to mirrorbits 1/2 Jan 9, 2024
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
@dduportal dduportal marked this pull request as ready for review January 9, 2024 08:19
@dduportal dduportal requested review from lemeurherve and smerle33 and removed request for lemeurherve January 9, 2024 08:19
Copy link
Contributor

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@dduportal
Copy link
Contributor Author

Note: checks are failing but for expected reasons:

  • Version bump checks fails with only ERROR: the version of the 'mirrorbits-lite' chart hasn't been bumped: ''. error (as we removed the chart)
  • Updatecli reports:
    • 1 changed dependency for mirrorbits-parent (expected as we introduce a new version of at least one of its subcharts)
    • 1 failure when searching for the mirrorbits image tag (expected as it is part of this change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants