NPE in SpotBugsProbe when plugin is not part of UpdateCenter (#253)

jenkins-infra · Mar 24, 2023 · 95ad433 · 95ad433
1 parent ed4c88d
commit 95ad433
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/core/src/main/java/io/jenkins/pluginhealth/scoring/probes/SpotBugsProbe.java b/core/src/main/java/io/jenkins/pluginhealth/scoring/probes/SpotBugsProbe.java
@@ -56,6 +56,9 @@ protected ProbeResult doApply(Plugin plugin, ProbeContext context) {
 
         final io.jenkins.pluginhealth.scoring.model.updatecenter.Plugin ucPlugin =
             context.getUpdateCenter().plugins().get(plugin.getName());
+        if (ucPlugin == null) {
+            return ProbeResult.error(key(), "This plugin is no longer in the update-center");
+        }
         final String defaultBranch = ucPlugin.defaultBranch();
         try {
             final Optional<String> repositoryName = context.getRepositoryName(plugin.getScm());

diff --git a/core/src/test/java/io/jenkins/pluginhealth/scoring/probes/SpotBugsProbeTest.java b/core/src/test/java/io/jenkins/pluginhealth/scoring/probes/SpotBugsProbeTest.java
@@ -231,4 +231,32 @@ pluginName, new VersionNumber("1.0"), scmLink, ZonedDateTime.now(), List.of(), 0
             .comparingOnlyFields("id", "status", "message")
             .isEqualTo(ProbeResult.failure(SpotBugsProbe.KEY, "SpotBugs not found in build configuration"));
     }
+
+    @Test
+    void shouldNotThrowExceptionWhenPluginRemovedFromUpdateCenter() {
+        final Plugin plugin = mock(Plugin.class);
+        final ProbeContext ctx = mock(ProbeContext.class);
+
+        when(plugin.getName()).thenReturn("mailer");
+        when(plugin.getDetails()).thenReturn(Map.of(
+            JenkinsfileProbe.KEY, ProbeResult.success(JenkinsfileProbe.KEY, "")
+        ));
+        when(ctx.getUpdateCenter()).thenReturn(new UpdateCenter(
+            Map.of(),
+            Map.of(),
+            List.of()
+        ));
+
+        final SpotBugsProbe probe = new SpotBugsProbe();
+        try {
+            final ProbeResult result = probe.apply(plugin, ctx);
+            assertThat(result)
+                .usingRecursiveComparison()
+                .comparingOnlyFields("id", "status", "message")
+                .isEqualTo(ProbeResult.error(SpotBugsProbe.KEY, "This plugin is no longer in the update-center"));
+        } catch (NullPointerException ex) {
+            assert false;
+        }
+
+    }
 }