Skip to content

Removes inactive maintainer from display-console-output plugin #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

alecharp
Copy link
Contributor

@alecharp alecharp commented Feb 3, 2025

The plugins has 2 pull requests open for a very long time, with no feedback from the maintainer.

This is meant to help the plugin be marked as up for adoption by the update-center.

I know there is no official rule for this process. This is what we tried to discuss at the 2025 contributor summit in FOSDEM.
I propose that we wait the 15 days as for adding new maintainers.

Link to GitHub repository

https://github.com/jenkinsci/display-console-output-plugin

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • N/A

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

  • The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to accounts.jenkins.io.
  • All users added have logged in to Artifactory and Jira once.
  • I have mentioned an existing team member of the plugin or component team to approve this request.

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

CD checklist (for submitters)

  • I have provided a link to the pull request in my plugin, which enables CD according to the documentation.

Reviewer checklist

  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it.

@alecharp alecharp requested a review from a team as a code owner February 3, 2025 10:21
@alecharp
Copy link
Contributor Author

alecharp commented Feb 5, 2025

I haven't pinge @lyenliang in my original message. I'm sorry for that. Let's wait 15days starting now.

@alecharp
Copy link
Contributor Author

I propose that, based on a the missing feedback, we merge this.

@timja timja merged commit bbf89eb into master Feb 25, 2025
4 checks passed
@timja timja deleted the chore/plugin-display-console-output-abandonned branch February 25, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants