fix: allow params from previous tasks results #1562
Conversation
|
Hi @JordanGoasdoue. Thanks for your PR. I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
|
/ok-to-test |
|
/retest |
JordanGoasdoue
force-pushed
the
fix/allow-tasks-results-params
branch
from
3ee72c9
to
d2263d9
Compare
There was a problem hiding this comment.
It's going to be migrated away from in future, so it's only temporary. I'm sure we could split hairs but I think that wouldn't be very time efficient.
We'll have to look at the Tekton support for this @JordanGoasdoue, to make sure that the new way would work for you.
Happy to merge this for now though so that we're fully supporting your implementation. Thanks for the PR!!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomhobson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thank you @tomhobson , I totally agree with you here, and again, well done for the support, it's really appreciated |
Hello,
I first want to thank you so much for the help to allow the upgrade to 1.25 @tomhobson @msvticket and all others i'm forgetting.
I am using params with as value the results from previous tasks.
It worked in jx 3.10.83, but since I have upgraded to 3.10.86 in order to upgrade my cluster to 1.25 it broke
I know that jx uses resolver will be removed, but in order to prepare the right way, I need to keep a little more the uses inside my jx3 catalog, and so this PR would help be a lot.