Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update go-scm #1637

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

Skisocks
Copy link
Contributor

@Skisocks Skisocks commented Jan 7, 2025

Latest go-scm add ListOptions to Contents.List interface (jenkins-x/go-scm#470). Added an empty ListOptions to satisfy the interface & update go-scm.

Resolves broken PRs #1634.

@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@Skisocks
Copy link
Contributor Author

Skisocks commented Jan 7, 2025

/cc @msvticket

Copy link
Member

@msvticket msvticket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1637]: [Method Not Allowed]

@jenkins-x-bot jenkins-x-bot merged commit efe21a2 into jenkins-x:main Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants