Add FSx Module

[AhmedAliMajid]

Testing done

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests that demonstrate the feature works or the issue is fixed

[MarkEWaite]

Please provide one or more examples of Jenkins plugins that will use this module. We don't want to add more modules unless there are Jenkins plugins that will consume those modules.

Please complete the pull request template, especially the "Testing done" section. Follow the detailed directions that are included in the comment within that section.

[AhmedAliMajid]

Hello @MarkEWaite

Thanks for reviewing the PR.

As far as understood each module in this repo is going to be a separated plugin that can be easily installed on Jenkins as required.
see here please.
https://plugins.jenkins.io/aws-java-sdk2-core/dependencies

All the modules that I have added are required by our project. And we need to migrate from aws java sdk v1 into v2 and get rid of Grab in our code.

I hope that make sense to have my PRs merged.

Thanks !

[MarkEWaite]

All the modules that I have added are required by our project. And we need to migrate from aws java sdk v1 into v2 and get rid of Grab in our code.

So you're proposing to create many more plugins but only using those new plugins from Groovy code in a Jenkins Pipeline? That seems like a mistake. Instead of calling the AWS CLI directly, you're loading Java libraries into the Jenkins controller so that you can call those libraries from Groovy code in the Pipeline. Call the AWS CLI directly rather than loading Java classes into the Jenkins controller.

Several of the AWS SDK 2 plugins that you are proposing to create do not exist in the AWS SDK (v1) plugin. Can you explain how you are using the following components today, since they do not exist as AS SDK (v1) plugins?

• ServiceQuotas
• Route53
• RAM
• KMS
• EKS
• FSx
• openSearch

The STS AWS Java SDK module is already included in the aws-java-sdk2-core plugin. An explanation is provided in the plugin documentation.

[shasait]

Hi @MarkEWaite,
in version 1 there is this plugin available: Amazon Web Services SDK :: All (https://github.com/jenkinsci/aws-java-sdk-plugin/blob/master/aws-java-sdk/pom.xml).
It is adding all sdk.jars not covered by plugins to the jenkins controller classpath.

In the project we started with a docker container wrapping aws-cli and then our pipeline code delegating to this container. But mapping json-requests and responses is adding a lot of overhead compared to making the controller directly doing the API call.
As you can imagine we are not talking here about CI but other kinds of automations. And I think that is one of the biggest strength of Jenkins compared to other CI-only solutions on the market - using Jenkins as automation platform and not only as CI/CD.

So for us it would be also good enough having this one extra plugin adding all remaining sdk.jars to the classpath as it was for v1.

Thanks a lot

[MarkEWaite]

So for us it would be also good enough having this one extra plugin adding all remaining sdk.jars to the classpath as it was for v1.

The maintainers of the AWS Java SDK (v1) plugin consider it a mistake to have provided that plugin that includes all remaining SDK jars. They were unwilling to repeat that mistake for the AWS Java SDK v2. You're welcome to build your own private plugin that packages all the remaining SDK jars, but the Jenkins project does not plan to do that.