Remove more CSP issues (#323)

jenkinsci · Nov 17, 2024 · 573775e · 573775e
1 parent 1a5b0db
commit 573775e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 21 deletions.
diff --git a/src/main/java/com/microsoftopentechnologies/windowsazurestorage/WAStoragePublisher.java b/src/main/java/com/microsoftopentechnologies/windowsazurestorage/WAStoragePublisher.java
@@ -73,6 +73,7 @@
 import org.kohsuke.stapler.DataBoundSetter;
 import org.kohsuke.stapler.QueryParameter;
 import org.kohsuke.stapler.StaplerRequest;
+import org.kohsuke.stapler.verb.POST;
 
 public class WAStoragePublisher extends Recorder implements SimpleBuildStep {
     private static final Logger LOGGER = Logger.getLogger(WAStoragePublisher.class.getName());
@@ -639,6 +640,7 @@ public boolean configure(StaplerRequest req, JSONObject formData)
          * @throws IOException
          * @throws ServletException
          */
+        @POST
         public FormValidation doCheckAccount(
                 //CHECKSTYLE:OFF
                 @QueryParameter String was_storageAccName,
@@ -671,17 +673,8 @@ public FormValidation doCheckAccount(
             return FormValidation.ok(Messages.WAStoragePublisher_SA_val());
         }
 
-        /**
-         * Checks for valid container name.
-         *
-         * @param request
-         * @return FormValidation result
-         * @throws IOException
-         * @throws ServletException
-         */
-        public FormValidation doCheckContainerName(StaplerRequest request)
-                throws IOException, ServletException {
-            final String containerName = request.getParameter("val");
+        @POST
+        public FormValidation doCheckContainerName(@QueryParameter("value") String containerName) {
             if (!StringUtils.isBlank(containerName)) {
                 // Token resolution happens dynamically at runtime , so for
                 // basic validations
@@ -696,8 +689,8 @@ public FormValidation doCheckContainerName(StaplerRequest request)
             }
         }
 
-        public FormValidation doCheckFileShareName(StaplerRequest request) {
-            final String fileShareName = request.getParameter("val");
+        @POST
+        public FormValidation doCheckFileShareName(@QueryParameter("value") String fileShareName) {
             if (!StringUtils.isBlank(fileShareName)) {
                 // Token resolution happens dynamically at runtime , so for
                 // basic validations
@@ -712,14 +705,16 @@ public FormValidation doCheckFileShareName(StaplerRequest request) {
             }
         }
 
-        public FormValidation doCheckPath(@QueryParameter String val) {
-            if (StringUtils.isBlank(val)) {
+        @POST
+        public FormValidation doCheckFilesPath(@QueryParameter String value) {
+            if (StringUtils.isBlank(value)) {
                 return FormValidation.error(Messages
                         .WAStoragePublisher_artifacts_req());
             }
             return FormValidation.ok();
         }
 
+        @POST
         public FormValidation doCheckBlobName(@QueryParameter String val) {
             if (StringUtils.isBlank(val)) {
                 return FormValidation.error(Messages

diff --git a/...sources/com/microsoftopentechnologies/windowsazurestorage/WAStoragePublisher/config.jelly b/...sources/com/microsoftopentechnologies/windowsazurestorage/WAStoragePublisher/config.jelly
@@ -6,8 +6,7 @@
         <c:select expressionAllowed="false"/>
     </f:entry>
     <f:entry title="${%filesPath_title}" field="filesPath" help="/plugin/windows-azure-storage/help-filesPath.html">
-        <f:textbox
-                checkUrl="'${rootURL}/publisher/WAStoragePublisher/checkPath?val='+encodeURIComponent(this.value)"/>
+        <f:textbox />
     </f:entry>
 
     <f:section title="${%storageType_title}">
@@ -17,8 +16,7 @@
             <f:nested>
                 <f:entry title="${%containerName_title}" field="containerName"
                          help="/plugin/windows-azure-storage/help-containerName.html">
-                    <f:textbox
-                            checkUrl="'${rootURL}/publisher/WAStoragePublisher/checkContainerName?val='+escape(this.value)"/>
+                    <f:textbox />
                 </f:entry>
             </f:nested>
         </f:radioBlock>
@@ -28,8 +26,7 @@
             <f:nested>
                 <f:entry title="${%fileShareName_title}" field="fileShareName"
                          help="/plugin/windows-azure-storage/help-azureFileShareName.html">
-                    <f:textbox
-                            checkUrl="'${rootURL}/publisher/WAStoragePublisher/checkFileShareName?val='+escape(this.value)"/>
+                    <f:textbox />
                 </f:entry>
             </f:nested>
         </f:radioBlock>