Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the provided style to the summary text #210

Conversation

madsjakobsen
Copy link
Contributor

add missing $ in summary template

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

add missing `$` in summary template
@madsjakobsen madsjakobsen requested a review from a team as a code owner November 14, 2024 14:48
Copy link
Contributor

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Nov 14, 2024

I confirmed that the incorrect style is added to the build job of the page when I run a Pipeline:

pipeline {
    agent any
    stages {
        stage('Badge') {
            steps {
                addSummary(icon: 'symbol-home-outline plugin-ionicons-api', 
                                   text: 'Sample', 
                                   link: 'https://jenkins.io')
            }
        }
    }
}

The HTML page for that build shows the "home" icon with the text "Sample" and the style is '{it.cssClass}' instead of being the expanded CSS class. I think that an automated test should be possible to check that, but even if there is not an automated test, my interactive test shows the bug before this change.

@mPokornyETM mPokornyETM merged commit 9ef9b84 into jenkinsci:master Nov 14, 2024
20 checks passed
@MarkEWaite MarkEWaite added the bug Something isn't working label Nov 14, 2024
@MarkEWaite
Copy link
Contributor

Testing after the change confirms that the style is no longer "{it.cssClass}"

@MarkEWaite MarkEWaite changed the title Add missing $ in summary template Apply the provided style to the summary text Nov 14, 2024
@strangelookingnerd strangelookingnerd mentioned this pull request Nov 19, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants