Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73961] Extract event handlers in BuildPipelineView/bpp.jelly #144

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[JENKINS-73961] Extract event handlers in BuildPipelineView/bpp.jelly #144

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b5ccdd4
Extract event handlers in
shlomomdahan Oct 30, 2024
85dcb4b
Extract event handlers in
shlomomdahan Oct 30, 2024
e40e43b
Extract event handlers in
shlomomdahan Oct 30, 2024
48c5392
Merge branch 'master' into JENKINS-73961
shlomomdahan Nov 8, 2024
bacdf49
remove redundant class
shlomomdahan Nov 8, 2024
16ccf5b
Merge branch 'master' into JENKINS-73961
shlomomdahan Nov 8, 2024
cfae875
remove redundant span, add attributes to trigger span
shlomomdahan Nov 8, 2024
5316ab9
Merge branch 'master' into JENKINS-73961
shlomomdahan Nov 8, 2024
76a6227
Update src/main/resources/au/com/centrumsystems/hudson/plugin/buildpi…
shlomomdahan Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .../com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp-trigger-pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Behaviour.specify(".bpp-trigger-pipeline-parameterized", 'BuildPipelineView.TriggerPipelineParameterized', 0, function(element) {
element.addEventListener('click', function() {
const paramsElement = document.querySelector('.bpp-trigger-pipeline-parameterized-params');
const href = paramsElement.dataset.fillDialogHref;
const title = paramsElement.dataset.fillDialogTitle;
buildPipeline.fillDialog(href, title);
});
});

Behaviour.specify(".bpp-trigger-pipeline-button", 'BuildPipelineView.TriggerPipeline', 0, function(element) {
element.addEventListener('click', function(e) {
shlomomdahan marked this conversation as resolved.
Show resolved Hide resolved
document.getElementById('triggerPipelineForm').submit();
});
});
6 changes: 4 additions & 2 deletions ...n/resources/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView/bpp.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
</j:if>

<st:adjunct includes="io.jenkins.plugins.jquery3"/>
<st:adjunct includes="au.com.centrumsystems.hudson.plugin.buildpipeline.BuildPipelineView.bpp-trigger-pipeline"/>
<script src="${rootURL}/plugin/build-pipeline-plugin/js/jquery-migrate-1.2.1.min.js"></script>
<script type="text/javascript" src="${rootURL}/plugin/build-pipeline-plugin/js/jquery-ui-1.8.14.custom.min.js"></script>
<script type="text/javascript" src="${rootURL}/plugin/build-pipeline-plugin/js/handlebars-1.0.0.beta.6.js"></script>
Expand Down Expand Up @@ -62,13 +63,14 @@
<j:if test="${hasBuildPermission}">
<div class="icon-container">
<j:if test="${from.isProjectParameterized()}">
<span class="pointer" onclick="buildPipeline.fillDialog('${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec', 'Starts the pipeline with parameters')">
<span class="bpp-trigger-pipeline-parameterized-params" data-fill-dialog-href="${app.rootUrl}${from.gridBuilder.firstJobLink}/build?delay=0sec" data-fill-dialog-title="Starts the pipeline with parameters" style="display: none" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the need for a different element to hold the data attributes? Is it not simpler to put them on the element on the next line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - I made the changed and tested that it is working. I'll note all things things for future PR to avoid bloating the DOM.

Thank you!

<span class="bpp-trigger-pipeline-parameterized pointer">
<l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
<span>Run</span>
</span>
</j:if>
<j:if test="${!from.isProjectParameterized()}">
<a id="trigger-pipeline-button" href='#' onclick="document.getElementById('triggerPipelineForm').submit()">
<a class="bpp-trigger-pipeline-button" id="trigger-pipeline-button" href='#'>
shlomomdahan marked this conversation as resolved.
Show resolved Hide resolved
<l:icon src="icon-clock icon-md" alt="Trigger a Pipeline" />
<span>Run</span>
</a>
Expand Down