-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul ui-samples as the Jenkins Design Library #14
Merged
Merged
Changes from 103 commits
Commits
Show all changes
112 commits
Select commit
Hold shift + click to select a range
d1d1918
Initial
janfaracik 8ec2f40
Getting there
janfaracik 6d3c084
Initial work with custom symbols + colors page
janfaracik e03e793
Add more components
janfaracik cff342b
Add radios example
janfaracik c8af226
Merge branch 'master' into overhaul
timja 80cdaf7
Rename several files
janfaracik 2839714
Update index.jelly
janfaracik 343347c
Replace progress bar page with jelly
janfaracik 3c1a1fe
Merge branch 'overhaul' of github.com:janfaracik/ui-samples-plugin in…
timja 56518f3
Add missing descriptors
timja cb51768
Tweak buttons page
timja 31d7027
Load example via JavaScript
timja afeec01
Update example
timja 2a6aec3
Remove test code
timja b28a1d5
Handle prism running before code loading
timja a335229
Update home page, add icons, update some content
janfaracik 367de54
Update homepage, add symbols content
janfaracik 251967a
Make remote loading easy
timja cfe01eb
Merge branch 'overhaul' of github.com:janfaracik/ui-samples-plugin in…
timja c677903
Add examples to symbols page
timja 0c8a781
Extract table sample out and show code sample without duplication
timja 567b2bd
Improve rendering of Notifications
timja 319d171
Improve button sample
timja 3c92243
Update buttons docs
timja ff928f8
More improvements
timja 3427e19
Add link to gitter
timja eca5946
Add checkboxes documentation
timja 1bb809c
Add more content to homepage
janfaracik d459a27
Merge branch 'overhaul' of https://github.com/janfaracik/ui-samples-p…
janfaracik 931ba87
Add links, update Gitter logo to be larger
janfaracik 077c81f
Update youtube.svg
janfaracik 724fc1a
Minor text change
timja 1b29e5f
Temp hack to improve App logo
timja 6fc0717
Re-brand to design library
timja be81e4c
Sync title and heading on home
timja 4ca07c3
Add some content around buttons
timja d3b8aa6
Add sunburst to Jenkins card
janfaracik 3d3dbe6
Merge branch 'overhaul' of https://github.com/janfaracik/ui-samples-p…
janfaracik bb9f53c
Copy changes
timja d847538
Merge branch 'overhaul' of github.com:janfaracik/ui-samples-plugin in…
timja 457272f
Remove something we don't want to promote
timja fc37d39
Narrowed it down a bit
timja ab6b502
Fix CSRF issues
timja bb54e7d
Update colors page, add code for progress
janfaracik de16802
Update progress
timja 866c8de
Merge branch 'overhaul' of github.com:janfaracik/ui-samples-plugin in…
timja d3cf9ef
Add rest of icons
janfaracik 49c2f90
Merge branch 'overhaul' of https://github.com/janfaracik/ui-samples-p…
janfaracik 5a0eff1
Remove titles
janfaracik c15f8f0
Remove unneeded data from SVGs
janfaracik cd32294
Improve select content
timja d7e8888
Cleanup CSS
janfaracik 179ee92
Merge branch 'overhaul' of github.com:janfaracik/ui-samples-plugin in…
timja a45f1f3
Minor improvements to text box
timja 3377aff
Update spacing, move code out of component sample div
janfaracik a54ec51
Merge branch 'master' into overhaul
janfaracik fe1f797
Update pom.xml
janfaracik 89d81a1
Update index.jelly
janfaracik 8a1fe68
Move progressively rendered page to progress
janfaracik 27b3ae1
Improve formatting
timja 4dafbe5
Add bit more to warning
timja d1f33ab
Add some examples to Validation
timja 4c125d2
Remove unused descriptions
timja 7316b01
Add example for basic textbox
timja 3d91e50
Fix textbox size in component box
janfaracik 44a9465
Set max width on samples, finish home content
janfaracik 5c74f68
Fix pom urls
timja 8198fbc
Rename in README
timja ee64398
Apply suggestions from code review
timja d2fa29a
Add some symbol guidance
timja 1fbafb9
Remove xmp
timja 9f297bf
Fix tooltip rendering
timja 96f77a7
Add code sample to dropdown dynamic
timja 5e0ebe7
Somewhat fix breadcrumb, content needs improving
timja 07218cd
Delete index.groovy
janfaracik 08853e0
Rename all packages
timja 672a4fa
Replace deprecated editable combo box
timja 99ac8bd
Remove select2 improve text box
timja 8d2f2a2
Add spacing details
janfaracik 46a7805
Update sample.css
janfaracik 696ac85
Update Colors.java
janfaracik 0be7211
Update src/main/resources/io/jenkins/plugins/designlibrary/Spacing/in…
janfaracik a3b4684
Button formatting improvements
timja b888a10
Fix checkbox formatting
timja a0d2a19
Add braces
timja c013ede
Add help button
janfaracik 0b9cbe1
Merge branch 'overhaul' of https://github.com/janfaracik/ui-samples-p…
janfaracik ed916b3
Update index.jelly
janfaracik d745fac
Add plugin name to class
timja 307413a
Merge branch 'overhaul' of github.com:janfaracik/ui-samples-plugin in…
timja 859dae2
Add missing plugin qualifier
timja 9e3e76f
adjunct must be loaded inside layout
timja 7378921
Polish
timja dfc8dbb
Add suggestion from Wadeck
timja 0f0836c
Cleanup links
timja 3e2cbe6
Add where to get artifact ID
timja fc972f0
Large numbers become max value
timja b1b8c55
Move dynamic dropdown to select
timja fcd5b6c
Syntax highlighting for heterolist
timja 3f75571
Iniital JavaScript proxy import from wiki
timja e5ca3eb
Polish JavaScript proxy
timja 6f95302
Add small docs for AppBar, add share button for supported browsers
janfaracik 80c9286
Polish app-bar
timja dce98fd
Add app-bar symbol
janfaracik 616a407
Fix share icon
janfaracik dec401a
Change icon to symbol
janfaracik 19bd345
Attempt at a fix/workaround for JS error
janfaracik 0348a01
Second potential fix
janfaracik 7639b13
Merge branch 'master' into overhaul
timja 31939f9
Merge branch 'overhaul' of github.com:janfaracik/ui-samples-plugin in…
timja 2e7081a
Disable test
timja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
root = true | ||
|
||
[*.{jelly, js, html, less, css, hbs}] | ||
indent_style = space | ||
indent_size = 2 | ||
trim_trailing_whitespace = true | ||
insert_final_newline = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,7 @@ | |
/work/ | ||
.project | ||
.classpath | ||
.settings/ | ||
.settings/ | ||
.idea/ | ||
.DS_Store | ||
*.iml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
src/main/java/io/jenkins/plugins/designlibrary/AppBar.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package io.jenkins.plugins.designlibrary; | ||
|
||
import hudson.Extension; | ||
|
||
@Extension | ||
public class AppBar extends UISample { | ||
@Override | ||
public String getDisplayName() { | ||
return "App bars"; | ||
} | ||
|
||
@Override | ||
public String getIconFileName() { | ||
return "symbol-app-bar"; | ||
timja marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
@Extension | ||
public static final class DescriptorImpl extends UISampleDescriptor { | ||
} | ||
} | ||
|
19 changes: 19 additions & 0 deletions
19
src/main/java/io/jenkins/plugins/designlibrary/Buttons.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package io.jenkins.plugins.designlibrary; | ||
|
||
import hudson.Extension; | ||
|
||
/** | ||
* @author Kohsuke Kawaguchi | ||
*/ | ||
@Extension | ||
public class Buttons extends UISample { | ||
@Override | ||
public String getIconFileName() { | ||
return "symbol-buttons"; | ||
} | ||
|
||
@Extension | ||
public static final class DescriptorImpl extends UISampleDescriptor { | ||
} | ||
} | ||
|
19 changes: 19 additions & 0 deletions
19
src/main/java/io/jenkins/plugins/designlibrary/Checkboxes.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
package io.jenkins.plugins.designlibrary; | ||
|
||
import hudson.Extension; | ||
|
||
/** | ||
* @author Kohsuke Kawaguchi | ||
*/ | ||
@Extension | ||
public class Checkboxes extends UISample { | ||
@Override | ||
public String getIconFileName() { | ||
return "symbol-checkboxes"; | ||
} | ||
|
||
@Extension | ||
public static final class DescriptorImpl extends UISampleDescriptor { | ||
} | ||
} | ||
|
25 changes: 25 additions & 0 deletions
25
src/main/java/io/jenkins/plugins/designlibrary/Colors.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package io.jenkins.plugins.designlibrary; | ||
|
||
import hudson.Extension; | ||
|
||
import java.util.Arrays; | ||
import java.util.List; | ||
|
||
@Extension | ||
public class Colors extends UISample { | ||
@Override | ||
public String getIconFileName() { | ||
return "symbol-colors"; | ||
} | ||
|
||
public List<String> getColors() { | ||
// Uncomment these once these colors are in core | ||
// return Arrays.asList("red", "green", "orange", "yellow", "blue", "indigo", "violet"); | ||
return Arrays.asList("red", "green", "orange"); | ||
} | ||
|
||
@Extension | ||
public static final class DescriptorImpl extends UISampleDescriptor { | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/main/java/io/jenkins/plugins/designlibrary/InpageNavigationWithBreadcrumb.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
package io.jenkins.plugins.designlibrary; | ||
|
||
import hudson.Extension; | ||
|
||
/** | ||
* @author Kohsuke Kawaguchi | ||
*/ | ||
@Extension | ||
public class InpageNavigationWithBreadcrumb extends UISample { | ||
@Extension | ||
public static final class DescriptorImpl extends UISampleDescriptor { | ||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
src/main/java/io/jenkins/plugins/designlibrary/Notifications.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package io.jenkins.plugins.designlibrary; | ||
|
||
import hudson.Extension; | ||
|
||
/** | ||
* @author Kohsuke Kawaguchi | ||
*/ | ||
@Extension | ||
public class Notifications extends UISample { | ||
@Override | ||
public String getIconFileName() { | ||
return "symbol-notifications"; | ||
} | ||
|
||
@Extension | ||
public static final class DescriptorImpl extends UISampleDescriptor { | ||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave the GAV as-is, because changing it basically creates a new plugin from the plugin manager's perspective which would result in
ui-samples-plugin
users not being able to update anymore anddesign-library
installations could install the ui-samples-plugin.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, given it hasn't been released in 8 years it's probably okay to change it, although likely we will want to change the package name as well.
(and also because there's no way this can affect users other than uninstalling the old one and installing the new one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it work out to suspend ui-samples from the update center noting it's superseded by design-library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possibly