Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul ui-samples as the Jenkins Design Library #14
Overhaul ui-samples as the Jenkins Design Library #14
Changes from 1 commit
d1d1918
8ec2f40
6d3c084
e03e793
cff342b
c8af226
80cdaf7
2839714
343347c
3c1a1fe
56518f3
cb51768
31d7027
afeec01
2a6aec3
b28a1d5
a335229
367de54
251967a
cfe01eb
c677903
0c8a781
567b2bd
319d171
3c92243
ff928f8
3427e19
eca5946
1bb809c
d459a27
931ba87
077c81f
724fc1a
1b29e5f
6fc0717
be81e4c
4ca07c3
d3b8aa6
3d3dbe6
bb9f53c
d847538
457272f
fc37d39
ab6b502
bb54e7d
de16802
866c8de
d3cf9ef
49c2f90
5a0eff1
c15f8f0
cd32294
d7e8888
179ee92
a45f1f3
3377aff
a54ec51
fe1f797
89d81a1
8a1fe68
27b3ae1
4dafbe5
d1f33ab
4c125d2
7316b01
3d91e50
44a9465
5c74f68
8198fbc
ee64398
d2fa29a
1fbafb9
9f297bf
96f77a7
5e0ebe7
07218cd
08853e0
672a4fa
99ac8bd
8d2f2a2
46a7805
696ac85
0be7211
a3b4684
b888a10
a0d2a19
c013ede
0b9cbe1
ed916b3
d745fac
307413a
859dae2
9e3e76f
7378921
dfc8dbb
0f0836c
3e2cbe6
fc972f0
b1b8c55
fcd5b6c
3f75571
e5ca3eb
6f95302
80c9286
dce98fd
616a407
dec401a
19bd345
0348a01
7639b13
31939f9
2e7081a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the spacing looks not good on the buttons
is that just the branch I'm using (jenkinsci/jenkins#6395)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is part of the latest weekly as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for that should be in with the help button component merge 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my branch has the help button component update in it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like html unit breaks on this syntax, https://github.com/jenkinsci/ui-samples-plugin/pull/14/checks?check_run_id=5716218242
missing formal parameter
may be related to HtmlUnit/htmlunit#232