Skip to content

Use spotbugs annotations instead of jsr305 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use spotbugs annotations instead of jsr305 #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/dubture/jenkins/digitalocean/RetentionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@
package com.dubture.jenkins.digitalocean;

import com.myjeeva.digitalocean.pojo.Droplet;
import edu.umd.cs.findbugs.annotations.NonNull;
import hudson.model.Descriptor;
import hudson.slaves.CloudSlaveRetentionStrategy;

import javax.annotation.Nonnull;
import java.util.concurrent.TimeUnit;

/**
Expand All @@ -42,7 +42,7 @@
public class RetentionStrategy extends CloudSlaveRetentionStrategy<DigitalOceanComputer> {

private static class DescriptorImpl extends Descriptor<hudson.slaves.RetentionStrategy<?>> {
@Nonnull
@NonNull
@Override
public String getDisplayName() {
return "DigitalOcean";
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/dubture/jenkins/digitalocean/Slave.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

package com.dubture.jenkins.digitalocean;

import edu.umd.cs.findbugs.annotations.NonNull;
import hudson.Extension;
import hudson.model.Descriptor;
import hudson.model.TaskListener;
Expand All @@ -37,7 +38,6 @@
import org.jenkinsci.plugins.cloudstats.ProvisioningActivity;
import org.jenkinsci.plugins.cloudstats.TrackedItem;

import javax.annotation.Nonnull;
import java.io.IOException;
import java.util.List;
import java.util.logging.Logger;
Expand Down Expand Up @@ -99,7 +99,7 @@ public Slave(ProvisioningActivity.Id provisioningId, String cloudName, String na

@Extension
public static class DescriptorImpl extends SlaveDescriptor {
@Nonnull
@NonNull
@Override
public String getDisplayName() {
return "DigitalOcean Agent";
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/com/dubture/jenkins/digitalocean/SlaveTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@
import java.util.logging.Level;
import java.util.logging.Logger;

import javax.annotation.Nonnull;

import com.google.common.base.Strings;
import com.myjeeva.digitalocean.exception.DigitalOceanException;
import com.myjeeva.digitalocean.exception.RequestUnsuccessfulException;
Expand All @@ -48,6 +46,7 @@
import com.myjeeva.digitalocean.pojo.Region;
import com.myjeeva.digitalocean.pojo.Size;

import edu.umd.cs.findbugs.annotations.NonNull;
import org.apache.commons.lang3.StringUtils;
import org.jenkinsci.plugins.cloudstats.ProvisioningActivity;
import org.kohsuke.stapler.DataBoundConstructor;
Expand Down Expand Up @@ -316,7 +315,7 @@ private Slave newSlave(ProvisioningActivity.Id provisioningId, String cloudName,

@Extension
public static final class DescriptorImpl extends Descriptor<SlaveTemplate> {
@Nonnull
@NonNull
@Override
public String getDisplayName() {
return "DigitalOcean Agent Template";
Expand Down