Bump org.jenkins-ci.plugins:plugin from 5.8 to 5.9 (#1730)

pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <groupId>org.jenkins-ci.plugins</groupId>
     <artifactId>plugin</artifactId>
-    <version>5.8</version>
+    <version>5.9</version>
     <relativePath />
   </parent>
 

src/main/java/hudson/plugins/git/browser/AssemblaWeb.java

@@ -20,7 +20,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.servlet.ServletException;
 import java.io.IOException;
 import java.io.Serial;
@@ -98,9 +97,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public AssemblaWeb newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public AssemblaWeb newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(AssemblaWeb.class, jsonObject);
         }
 

src/main/java/hudson/plugins/git/browser/BitbucketServer.java

@@ -11,7 +11,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -81,9 +80,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public BitbucketServer newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public BitbucketServer newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(BitbucketServer.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/BitbucketWeb.java

@@ -11,7 +11,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -82,9 +81,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public BitbucketWeb newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public BitbucketWeb newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(BitbucketWeb.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/CGit.java

@@ -13,7 +13,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -92,9 +91,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public CGit newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public CGit newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(CGit.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/FisheyeGitRepositoryBrowser.java

@@ -17,7 +17,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.servlet.ServletException;
 import java.io.IOException;
 import java.io.Serial;
@@ -79,9 +78,7 @@ public String getDisplayName() {
 		}
 
 		@Override
-                @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                                    justification = "Inherited javadoc commits that req is non-null")
-		public FisheyeGitRepositoryBrowser newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+		public FisheyeGitRepositoryBrowser newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
 			return req.bindJSON(FisheyeGitRepositoryBrowser.class, jsonObject);
 		}
 

src/main/java/hudson/plugins/git/browser/GitBlitRepositoryBrowser.java

@@ -20,7 +20,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.servlet.ServletException;
 import java.io.IOException;
 import java.io.Serial;
@@ -90,9 +89,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public GitBlitRepositoryBrowser newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public GitBlitRepositoryBrowser newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(GitBlitRepositoryBrowser.class, jsonObject);
         }
 

src/main/java/hudson/plugins/git/browser/GitLab.java

@@ -19,7 +19,6 @@
 import java.net.URL;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.servlet.ServletException;
 
 import org.kohsuke.stapler.QueryParameter;
@@ -145,9 +144,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public GitLab newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public GitLab newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(GitLab.class, jsonObject);
         }
 

src/main/java/hudson/plugins/git/browser/GitList.java

@@ -13,7 +13,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -94,9 +93,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public GitList newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public GitList newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(GitList.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/GitWeb.java

@@ -13,7 +13,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -94,9 +93,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public GitWeb newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public GitWeb newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(GitWeb.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/GithubWeb.java

@@ -13,7 +13,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -100,9 +99,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-		public GithubWeb newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public GithubWeb newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
 			return req.bindJSON(GithubWeb.class, jsonObject);
 		}
 	}

src/main/java/hudson/plugins/git/browser/Gitiles.java

@@ -17,7 +17,6 @@
 import java.net.URL;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.servlet.ServletException;
 
 import net.sf.json.JSONObject;
@@ -72,9 +71,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public Gitiles newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public Gitiles newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(Gitiles.class, jsonObject);
         }
 

src/main/java/hudson/plugins/git/browser/GitoriousWeb.java

@@ -11,7 +11,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -76,9 +75,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public GitoriousWeb newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public GitoriousWeb newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(GitoriousWeb.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/GogsGit.java

@@ -13,7 +13,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -102,9 +101,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public GogsGit newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public GogsGit newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(GogsGit.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/KilnGit.java

@@ -14,7 +14,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -113,9 +112,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public KilnGit newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public KilnGit newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(KilnGit.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/Phabricator.java

@@ -11,7 +11,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -92,9 +91,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public Phabricator newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public Phabricator newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(Phabricator.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/RedmineWeb.java

@@ -12,7 +12,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -95,9 +94,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public RedmineWeb newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public RedmineWeb newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(RedmineWeb.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/RhodeCode.java

@@ -13,7 +13,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -97,9 +96,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public RhodeCode newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public RhodeCode newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(RhodeCode.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/Stash.java

@@ -12,7 +12,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
 import java.io.Serial;
 import java.net.URL;
@@ -97,9 +96,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public Stash newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public Stash newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(Stash.class, jsonObject);
         }
     }

src/main/java/hudson/plugins/git/browser/TFS2013GitRepositoryBrowser.java

@@ -19,7 +19,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.servlet.ServletException;
 import java.io.IOException;
 import java.net.MalformedURLException;
@@ -93,9 +92,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public TFS2013GitRepositoryBrowser newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public TFS2013GitRepositoryBrowser newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             try {
                 req.getSubmittedForm();
             } catch (ServletException e) {

src/main/java/hudson/plugins/git/browser/ViewGitWeb.java

@@ -21,7 +21,6 @@
 import org.kohsuke.stapler.StaplerRequest2;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import jakarta.servlet.ServletException;
 import java.io.IOException;
 import java.io.Serial;
@@ -91,9 +90,7 @@ public String getDisplayName() {
         }
 
         @Override
-        @SuppressFBWarnings(value = "NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE",
-                            justification = "Inherited javadoc commits that req is non-null")
-        public ViewGitWeb newInstance(StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
+        public ViewGitWeb newInstance(@NonNull StaplerRequest2 req, @NonNull JSONObject jsonObject) throws FormException {
             return req.bindJSON(ViewGitWeb.class, jsonObject);
         }