update to Jenkins LTS Version 2.289.2 - to release JENKINS-64639

[roebi]

to easier release this Jenkins Ticket https://issues.jenkins.io/browse/JENKINS-64639

i update some dependency to focus Jenkins LTS Version 2.289.2

• Update Parent POM - form https://www.jenkins.io/doc/developer/plugin-development/updating-parent/
• update maven reporting plugins
• update to plugin 4.9, fix RequireUpperBoundDeps
• update to parameterized-trigger plugin 2.30 without RequireUpperBoundDeps Exceptions
• add optional dependency to mailer plugin, update to Jenkins LTS Version 2.289.2, Jave Level 8
• Update Help Links to https://issues.jenkins.io
• Update Help Text paramaterized-trigger plugin Version
• .gitignore with IDEA ignores
• Update JoinTriggerAllCombinationsTest mavenProject Builder
• update org.jenkins-ci.plugins:plugin to 4.16, change from findbugs-maven-plugin to spotbugs-maven-plugin, can not use htmlunit, add Jelly XSS prevention
• correct deprecated Method Jenkins.getInstance() -> Jenkins.get()
• correct deprecated Class UserCause -> UserIdCause, correct deprecated Method Hudson.getInstance() -> Jenkins.get()
• define the used Parameter KEY on the join Job because of https://www.jenkins.io/blog/2016/05/11/security-update/
• Jenkins Projects use unique Job Names, correct deprecated Class UserCause -> UserIdCause, update maven-empty-mod.zip with new Versions
• define the used Parameter KEY on the intermediate Job because of https://www.jenkins.io/blog/2016/05/11/security-update/
• define the used Parameter KEY only on join Jobs with Parameter because of https://www.jenkins.io/blog/2016/05/11/security-update/
• because of https://www.jenkins.io/blog/2018/01/13/jep-200/ Refusing to marshal join.JoinTrigger for security reasons; see https://jenkins.io/redirect/class-filter/
  add resources/META-INF/hudson.remoting.ClassFilter with Entry join.JoinTrigger
  Co-authored-by: Robert Halter robert.halter@adcubum.com

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  roebi:update_to_jenkins2_289_2

• Ensure that the pull request title represents the desired changelog entry
  update to Jenkins LTS Version 2.289.2 - to release JENKINS-64639

• Please describe what you did
  see commit log entry

• Link to relevant issues in GitHub or Jira
  https://issues.jenkins.io/browse/JENKINS-64639 is already fixed in master branch

• Link to relevant pull requests, esp. upstream and downstream changes
  this pull Request start from 682cfed

• Ensure you have provided tests - that demonstrates feature works or fixes the issue
  all existing Tests are running again mvn verify / mvn cobertura:cobertura
  unsure about disabling Lines webClient.setThrowExceptionOnFailingAjax(false); // from htmlunit
  in the Tests
  testRoundTrip https://github.com/roebi/join-plugin/blob/update_to_jenkins2_289_2/src/test/java/join/JoinTriggerTest.java#L204
  testRoundTripWithPublishers https://github.com/roebi/join-plugin/blob/update_to_jenkins2_289_2/src/test/java/join/JoinTriggerTest.java#L220

[roebi]

@MarkEWaite Is it possible to receive a review from you for this pull request?

[MarkEWaite]

I'm not entirely sure why my review was requested, but I performed an initial review.

The changes look good to me. Each of them seems like a very reasonable step to modernize the plugin.

I don't see anything that is addressing JENKINS-64639, but I assume this is preparatory work being done before the specific changes for JENKINS-64639.

[roebi]

@wolfs it ist possible to merge the pull request in a new Branch i.e. 'update_to_jenkins2_289_2' in this Repo ?
Then the Units Tests will be run in this Branch on ci.jenkins.io - see https://ci.jenkins.io/job/Plugins/job/join-plugin/indexing/console

current this Pullrequest ist ignored for the Unit Tests:
Checking pull request #18 (not from a trusted source) ‘Jenkinsfile’ not found Does not meet criteria

[nicliuqi]

Sorry to comment here, but I found no place to know when the issue JENKINS-64639 can be resolved. Has Join Plugin stopped maintenance?

[MarkEWaite]

Sorry to comment here, but I found no place to know when the issue JENKINS-64639 can be resolved. Has Join Plugin stopped maintenance?

According to the page for the Join plugin, the last release was 5 years ago. The last commit to the GitHub repository was 7 months ago.

The fix for JENKINS-64639 was merged in March 2021, but no release has been performed. I think it is safe to call the plugin "abandoned". You can compile the plugin yourself and use your locally compiled version in your Jenkins controller, either using the master branch or using the changes on this branch.

See the "Adopt a plugin" instructions if you'd like to become the maintainer of this plugin.

[roebi]

Sorry to comment here, but I found no place to know when the issue JENKINS-64639 can be resolved. Has Join Plugin stopped maintenance?

Nobody does Releasing.

The last Release is from 2016. See https://github.com/jenkinsci/join-plugin/tags

I update to make releasing possible. The Table to Div fix ist already merged with a other Pull Request.

Current we have switched to Pipeline Jobs and do no more use this plugin.

[nicliuqi]

Thanks for your reply.

…

------------------ 原始邮件 ------------------ 发件人: "jenkinsci/join-plugin" ***@***.***>; 发送时间: 2021年12月6日(星期一) 晚上8:49 ***@***.***>; ***@***.******@***.***>; 主题: Re: [jenkinsci/join-plugin] update to Jenkins LTS Version 2.289.2 - to release JENKINS-64639 (#18) Sorry to comment here, but I found no place to know when the issue JENKINS-64639 can be resolved. Has Join Plugin stopped maintenance? Nobody does Releasing. The last Release is from 2016. See https://github.com/jenkinsci/join-plugin/tags I update to make releasing possible. The Table to Div fix ist already merged with a other Pull Request. Current we have switched to Pipeline Jobs and do no more use this plugin. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.