[JENKINS-74095] [JENKINS-74096] [JENKINS-74097] [JENKINS-74099] Remov…

…e legacy checkUrl handlers (#146) * remove legacy inline onClick handler in AbstractPlotPublisher/config.jelly * remove legacy inline onClick handlers * use checkDepends on for Pipeline compatibility * use checkDepends on for Pipeline compatibility --------- Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
jenkinsci · Nov 25, 2024 · efbb7f5 · efbb7f5
1 parent 708a631
commit efbb7f5
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/config.jelly b/src/main/resources/hudson/plugins/plot/AbstractPlotPublisher/config.jelly
@@ -66,9 +66,8 @@
         <f:entry title="" description="${%A new data series definition}">
           <f:repeatable var="series" items="${plot.series}" minimum="1">
             <div>
-              <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
-                <f:textbox name="file" value="${series.file}"
-                           checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)" />
+              <f:entry title="${%Data series file}" field="seriesFile" help="/plugin/plot/help-series.html">
+                <f:textbox name="file" value="${series.file}"/>
               </f:entry>
 
               <f:radioBlock name="fileType" value="properties" title="${%Load data from properties file}" help="/plugin/plot/help-properties.html" checked="${series.fileType=='properties' or series.fileType==null}">

diff --git a/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly b/src/main/resources/hudson/plugins/plot/CSVSeries/config.jelly
@@ -5,7 +5,8 @@
         <div>
             <f:entry title="${%Data series file}" field="file" help="/plugin/plot/help-series.html">
                 <f:textbox name="file" value="${series.file}"
-                           checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)"/>
+                           checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
+                           checkDependsOn="" />
             </f:entry>
             <f:nested>
                 <div>

diff --git a/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly b/src/main/resources/hudson/plugins/plot/PropertiesSeries/config.jelly
@@ -4,7 +4,8 @@
     <div>
     <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
         <f:textbox name="file" value="${series.file}"
-                   checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)" />
+                   checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
+                   checkDependsOn="" />
     </f:entry>
         <f:nested>
             <f:entry title="${%Data series legend label}" help="/plugin/plot/help-legend.html">

diff --git a/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly b/src/main/resources/hudson/plugins/plot/XMLSeries/config.jelly
@@ -4,7 +4,8 @@
     <div>
     <f:entry title="${%Data series file}" help="/plugin/plot/help-series.html">
         <f:textbox name="file" value="${series.file}"
-                   checkUrl="'descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile?value='+toValue(this)" />
+                   checkUrl="descriptorByName/hudson.plugins.plot.PlotPublisher/checkSeriesFile"
+                   checkDependsOn="" />
     </f:entry>
         <f:nested>
             <div>