Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky WorkflowRunTest.logRotationOnlyProcessesCompletedBuilds on Windows #502

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Flaky WorkflowRunTest.logRotationOnlyProcessesCompletedBuilds on Windows #502

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
252368c
Flaky `WorkflowRunTest.logRotationOnlyProcessesCompletedBuilds` on Wi…
jglick Jan 14, 2025
6ce8e85
Suppress in Windows CI for now, since I cannot reproduce locally, and…
jglick Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,9 @@
package org.jenkinsci.plugins.workflow.job;

import static org.awaitility.Awaitility.await;
import static org.hamcrest.collection.IsEmptyCollection.empty;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.emptyArray;
import static org.hamcrest.Matchers.empty;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.notNullValue;
Expand All @@ -48,6 +47,7 @@
import hudson.AbortException;
import hudson.Extension;
import hudson.ExtensionList;
import hudson.Functions;
import hudson.XmlFile;
import hudson.model.*;
import hudson.model.listeners.RunListener;
Expand Down Expand Up @@ -99,6 +99,7 @@
import org.jenkinsci.plugins.workflow.job.properties.DisableConcurrentBuildsJobProperty;
import org.jenkinsci.plugins.workflow.support.actions.EnvironmentAction;
import org.jenkinsci.plugins.workflow.test.steps.SemaphoreStep;
import static org.junit.Assume.assumeFalse;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Rule;
Expand Down Expand Up @@ -697,6 +698,7 @@

@Issue("JENKINS-73835")
@Test public void logRotationOnlyProcessesCompletedBuilds() throws Throwable {
assumeFalse("TODO #502: failing in VMs", Functions.isWindows() && "true".equals(System.getenv("CI")));

Check warning on line 701 in src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunTest.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO 

NORMAL:
#502: failing in VMs", Functions.isWindows() && "true".equals(System.getenv("CI")));
logging.record(LogRotator.class, Level.FINER);
var p = r.createProject(WorkflowJob.class);
p.setDefinition(new CpsFlowDefinition(
Expand Down Expand Up @@ -725,11 +727,14 @@
}
LOGGER.info("Checking that all build directories are empty");
for (int i = 0; i < buildsToRun; i++) {
String[] filesInBuildDir = buildDirs[i].list();
if (filesInBuildDir == null) {
filesInBuildDir = new String[0];
}
assertThat("Expected " + buildDirs[i] + " to be empty but saw: " + Arrays.toString(filesInBuildDir), filesInBuildDir, emptyArray());
var dir = buildDirs[i];
await(dir + " should be empty").until(() -> {
var filesInBuildDir = dir.list();
if (filesInBuildDir == null) {
filesInBuildDir = new String[0];
}
return Arrays.asList(filesInBuildDir);
}, empty());
}
}

Expand Down
Loading