Option to not include zstd and zlib #289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
In general I think most users should just build with compression support even if they aren't compiling with compressed debug symbols (though that being said, maybe consider compressing your debug symbols? iirc it can actually speed up link time). But, having a flag here doesn't hurt too much. One comment on naming and then happy to merge :)
cmake/OptionVariables.cmake
Outdated
| option(CPPTRACE_USE_EXTERNAL_LIBDWARF "" OFF) | ||
| option(CPPTRACE_FIND_LIBDWARF_WITH_PKGCONFIG "" OFF) | ||
| option(CPPTRACE_USE_EXTERNAL_ZSTD "" OFF) | ||
| option(CPPTRACE_ENABLE_DEBUG_DECOMPRESSION "" ON) |
There was a problem hiding this comment.
Maybe CPPTRACE_ENABLE_LIBDWARF_COMPRESSION_SUPPORT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an use case to compile an application, fetch the cpptrace and necessary libdwarf. But I don't need to produce compressed debug sections in DWARF format. So fetching and compiling zstd is a waste of time and space IMO.
I added option
CPPTRACE_ENABLE_DEBUG_DECOMPRESSION(which is defaultON), to be able to disable fetching of zstd both in cpptrace and libdwarf.