refactor(types): fix some type errors in Farmhand component

jeremyckahn · Aug 3, 2023 · 9a7a245 · 9a7a245
1 parent c936467
commit 9a7a245
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/components/Farmhand/Farmhand.js b/src/components/Farmhand/Farmhand.js
@@ -1149,8 +1149,11 @@ export default class Farmhand extends FarmhandReducers {
             // shown to the player when the app reloads.
             newDayNotifications: pendingNotifications,
           })
-          ;[]
-            .concat(pendingNotifications)
+
+          /** @type {farmhand.notification[]} */
+          const notifications = [...pendingNotifications]
+
+          notifications
             .concat(
               isFirstDay
                 ? []
@@ -1197,7 +1200,7 @@ export default class Farmhand extends FarmhandReducers {
   }
 
   focusNextView() {
-    if (document.activeElement.getAttribute('role') === 'tab') return
+    if (document.activeElement?.getAttribute('role') === 'tab') return
 
     const { viewList } = this
 
@@ -1209,7 +1212,7 @@ export default class Farmhand extends FarmhandReducers {
   }
 
   focusPreviousView() {
-    if (document.activeElement.getAttribute('role') === 'tab') return
+    if (document.activeElement?.getAttribute('role') === 'tab') return
 
     const { viewList } = this
 
@@ -1347,6 +1350,8 @@ export default class Farmhand extends FarmhandReducers {
                     position="static"
                     activeStep={viewList.indexOf(this.state.stageFocus)}
                     className=""
+                    backButton={null}
+                    nextButton={null}
                   />
                   <div className="fab-buttons buttons">
                     <Fab

diff --git a/src/index.js b/src/index.js
@@ -182,7 +182,7 @@
  * @typedef farmhand.notification
  * @type {Object}
  * @property {'error'|'info'|'success'|'warning'} severity
- * @property {Function?} onClick
+ * @property {Function=} onClick
  * @property {string} message
  */