feat(project): Replace Create React App with Vite #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(config): treat .js files as .jsx chore(project): rename .jsx files to .js
chore(project): [wip] await importActual
chore(project): [wip] fix broken test chore(project): [wip] fix broken test chore(project): [wip] fix broken test chore(project): [wip] fix broken test chore(project): [wip] fix broken test chore(project): [wip] fix broken test
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeremyckahn
commented
Aug 30, 2024
Comment on lines
-86
to
-117
| describe('fertilize-mode class', () => { | ||
| test('is not present when fieldMode != FERTILIZE', () => { | ||
| expect(component.find('.Field').hasClass('fertilize-mode')).toBeFalsy() | ||
| }) | ||
|
|
||
| test('is present when fieldMode == FERTILIZE', () => { | ||
| component.setProps({ fieldMode: fieldMode.FERTILIZE }) | ||
| expect(component.find('.Field').hasClass('fertilize-mode')).toBeTruthy() | ||
| }) | ||
| }) | ||
|
|
||
| describe('plant-mode class', () => { | ||
| test('is not present when fieldMode != PLANT', () => { | ||
| expect(component.find('.Field').hasClass('plant-mode')).toBeFalsy() | ||
| }) | ||
|
|
||
| test('is present when fieldMode == PLANT', () => { | ||
| component.setProps({ fieldMode: fieldMode.PLANT }) | ||
| expect(component.find('.Field').hasClass('plant-mode')).toBeTruthy() | ||
| }) | ||
| }) | ||
|
|
||
| describe('harvest-mode class', () => { | ||
| test('is not present when fieldMode != HARVEST', () => { | ||
| expect(component.find('.Field').hasClass('harvest-mode')).toBeFalsy() | ||
| }) | ||
|
|
||
| test('is present when fieldMode == HARVEST', () => { | ||
| component.setProps({ fieldMode: fieldMode.HARVEST }) | ||
| expect(component.find('.Field').hasClass('harvest-mode')).toBeTruthy() | ||
| }) | ||
| }) |
There was a problem hiding this comment.
These and the removed tests below are obviated by src/shell/field.test.js, introduced by this PR:
farmhand/src/shell/field.test.js
Lines 15 to 81 in 2b8721e
jeremyckahn
commented
Aug 30, 2024
| @@ -22,7 +22,7 @@ export const purchaseForest = (state, forestId) => { | |||
| const { columns, price, rows } = PURCHASABLE_FOREST_SIZES.get(forestId) | |||
|
|
|||
| /* | |||
| * FIXME: using FOREST_AVAILABLE_NOTIFICATION here is temporary, this code path will | |||
| * TODO: using FOREST_AVAILABLE_NOTIFICATION here is temporary, this code path will | |||
There was a problem hiding this comment.
FYI @lstebner I changed this from a FIXME to a TODO. I find it helpful to treat FIXMEs as an indication that something that needs to be addressed before a PR is merged, whereas a TODO indicates an improvement to be optionally made at some point in the future.
jeremyckahn
commented
Aug 30, 2024
Comment on lines
-41
to
-53
| describe('fieldMode === PLANT', () => { | ||
| beforeEach(() => { | ||
| handlers().handleFieldModeSelect(fieldMode.PLANT) | ||
| }) | ||
|
|
||
| test('updates fieldMode state', () => { | ||
| expect(component.state().fieldMode).toEqual(fieldMode.PLANT) | ||
| }) | ||
|
|
||
| test('does not change state.selectedItemId', () => { | ||
| expect(component.state().selectedItemId).toEqual('sample-crop-3') | ||
| }) | ||
| }) |
There was a problem hiding this comment.
These have also been obviated by src/shell/field.test.js.
jeremyckahn
added a commit
that referenced
this pull request
Aug 30, 2024
This reverts commit 4e05344.
jeremyckahn
added a commit
that referenced
this pull request
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Drop Create React App in favor of Vite. CRA is unmaintained, so this project would do well to transition to something more modern.
How this change can be validated
Questions or concerns about this change
I tried to keep the scope of this change as narrow as possible, but it still touches pretty much everything in the project. We'll probably find something broken after the fact, so we'll just have to fix forward if that's the case.