Skip to content

Commit

Permalink
Initialize AdmissibilityCondition::ratio_
Browse files Browse the repository at this point in the history
g++ 13.1.0 may report a warning when deriving new admissibility conditions
from AdmissibilityCondition:

    In copy constructor ‘constexpr hmat::AdmissibilityCondition::AdmissibilityCondition(const hmat::AdmissibilityCondition&)’,
    hmat-oss/src/admissibility.hpp:39:7: error: ‘AdmissibilityCondition::ratio_’ may be used uninitialized [-Werror=maybe-uninitialized]

In StandardAdmissibilityCondition constructor we use 0 as default value,
so it seems reasonable to use the same default in AdmissibilityCondition.
  • Loading branch information
dbarbier committed Aug 11, 2023
1 parent e803d7c commit 28b12a7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/admissibility.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class AxisAlignedBoundingBox;
class AdmissibilityCondition
{
public:
AdmissibilityCondition() : maxWidth_((size_t)-1L) {}
AdmissibilityCondition() : ratio_(0.0), maxWidth_((size_t)-1L) {}
/*! \brief Virtual copy constructor */
virtual AdmissibilityCondition * clone() const = 0;

Expand Down

0 comments on commit 28b12a7

Please sign in to comment.