Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #103

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

dogukancagatay
Copy link
Contributor

Description

Due to some changes in Python 3.13, the algorithm selector Enum (Algorithms) failed to initialize provided split algorithms as members.

The changes add support for Python 3.13 (tested with Python 3.13-rc1) and include converting the algorithm implementations to classes with proper hashing capability.

Checklist

  • Tests covering the new functionality have been added
  • Documentation has been updated OR the changes are too minor to be documented
  • The Changes are listed in the CHANGELOG.md OR the changes are insignificant

The algorithm selector Enum was failing to initialize provided split
algorithms as members due to some changes in Python 3.13.

The changes include the conversion of the algorithm implementations to
classes with proper hashing capability for better enum support, and
tests.
@jerry-git
Copy link
Owner

Thank you and sorry it took a while! Looks good 👍

Btw, I noticed that there are no workflow runs in your fork: https://github.com/dogukancagatay/pytest-split/actions. I wonder if there's something messed up in the trigger conditions of the test.yml workflow of this repo:

on:
pull_request:
push:
branches:
- "**"

Or have you disabled workflow runs in your repo or is this some GitHub security feature 🤔

@jerry-git jerry-git merged commit 2ff68b5 into jerry-git:master Oct 16, 2024
10 checks passed
@jerry-git
Copy link
Owner

This is now released in 0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants