Skip to content

Commit

Permalink
Merge pull request #68 from Daoortor/remove-kotlin-js
Browse files Browse the repository at this point in the history
Remove kotlin/js
  • Loading branch information
Daoortor authored Jul 30, 2024
2 parents ec60b18 + e67b847 commit 16692e0
Show file tree
Hide file tree
Showing 115 changed files with 190 additions and 161 deletions.
13 changes: 1 addition & 12 deletions build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ tasks {
val frontendSuffix = "Frontend"
val server = "Server"

configure(subprojects.filter { it.name != "common" && frontendSuffix !in it.name }) {
configure(subprojects.filter { frontendSuffix !in it.name }) {
apply<io.gitlab.arturbosch.detekt.DetektPlugin>()

apply {
Expand Down Expand Up @@ -140,7 +140,6 @@ configure(subprojects.filter { server in it.name }) {
}

dependencies {
implementation(project(":common"))
implementation(project(":utils"))

implementation("org.springframework.boot:spring-boot-starter-web")
Expand Down Expand Up @@ -181,16 +180,6 @@ configure(subprojects.filter { frontendSuffix in it.name }) {
installScript.set("install")
}

val addCommonTypesTask = tasks.register<Exec>("addCommonTypes") {
outputs.upToDateWhen { false }
workingDir = projectDir
commandLine("yarn", "remove", "common-types")
commandLine("yarn", "add", "common-types@file:$rootDir/common/build/libs/common-types")
}
addCommonTypesTask {
mustRunAfter(":common:build")
}

val yarnRunBuildTask = tasks.register<Exec>("yarnRunBuildTask") {
commandLine("yarn", "run", "build")
}
Expand Down
33 changes: 0 additions & 33 deletions common/build.gradle.kts

This file was deleted.

12 changes: 0 additions & 12 deletions common/src/commonMain/kotlin/duck/shop/Duck.kt

This file was deleted.

13 changes: 0 additions & 13 deletions common/src/commonMain/kotlin/old/school/Photo.kt

This file was deleted.

5 changes: 2 additions & 3 deletions duckShopFrontend/src/components/DuckContainer.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {duck} from "common-types";
import JsDuck = duck.shop.JsDuck;
import {JsDuck} from '../models/Duck';
import {DuckInfo} from "../models/DuckInfo";
import Duck from "./Duck";

Expand All @@ -13,7 +12,7 @@ export default function DuckContainer({ducks, pressedFunction}: DuckContainerPro
if (ducks.length > index) {
return new DuckInfo(ducks[index])
}
return new DuckInfo(new JsDuck("", null, false))
return new DuckInfo(new JsDuck())
}

return(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import {GameState} from "../GameScreen";
import {useState} from "react";
import {duck} from "common-types";
import JsDuck = duck.shop.JsDuck;
import {JsDuck} from '../../models/Duck';
import axios from "axios";
import DuckContainer from "../DuckContainer";

Expand Down
14 changes: 14 additions & 0 deletions duckShopFrontend/src/models/Duck.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import {Nullable} from "common-types";


export class JsDuck {
constructor(name: string = "", description: Nullable<string> = null, hasKotlinAttribute: boolean = false) {
this.name = name
this.description = description
this.hasKotlinAttribute = hasKotlinAttribute
}

name: string
description: Nullable<string> = null
hasKotlinAttribute: Boolean = false
}
3 changes: 1 addition & 2 deletions duckShopFrontend/src/models/DuckInfo.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {Nullable} from "common-types";
import {duck} from "common-types";
import JsDuck = duck.shop.JsDuck;
import {JsDuck} from './Duck';

export class DuckInfo {
imageClass: Nullable<string>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package org.jetbrains.kotlin.course.duck.shop.duck

data class JsDuck(val name: String, val description: String?, val hasKotlinAttribute: Boolean)
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.action

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.change

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.mode

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
import org.jetbrains.kotlin.course.duck.shop.utils.toJsDuck
import org.springframework.web.bind.annotation.CrossOrigin
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.utils

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.Duck
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package org.jetbrains.kotlin.course.duck.shop.duck

data class JsDuck(val name: String, val description: String?, val hasKotlinAttribute: Boolean)
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.action

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.change

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.mode

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
import org.jetbrains.kotlin.course.duck.shop.utils.toJsDuck
import org.springframework.web.bind.annotation.CrossOrigin
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.utils

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.Duck
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package org.jetbrains.kotlin.course.duck.shop.duck

data class JsDuck(val name: String, val description: String?, val hasKotlinAttribute: Boolean)
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.action

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.change

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.mode

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
import org.jetbrains.kotlin.course.duck.shop.utils.toJsDuck
import org.springframework.web.bind.annotation.CrossOrigin
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.utils

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.Duck
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package org.jetbrains.kotlin.course.duck.shop.duck

data class JsDuck(val name: String, val description: String?, val hasKotlinAttribute: Boolean)
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.action

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.change

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.mode

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
import org.jetbrains.kotlin.course.duck.shop.utils.toJsDuck
import org.springframework.web.bind.annotation.CrossOrigin
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.utils

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.Duck
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package org.jetbrains.kotlin.course.duck.shop.duck

data class JsDuck(val name: String, val description: String?, val hasKotlinAttribute: Boolean)
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.action

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.change

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.mode

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
import org.jetbrains.kotlin.course.duck.shop.utils.toJsDuck
import org.springframework.web.bind.annotation.CrossOrigin
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.utils

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.Duck
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package org.jetbrains.kotlin.course.duck.shop.duck

data class JsDuck(val name: String, val description: String?, val hasKotlinAttribute: Boolean)
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.action

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.change

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.mode

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
import org.jetbrains.kotlin.course.duck.shop.utils.toJsDuck
import org.springframework.web.bind.annotation.CrossOrigin
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.utils

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.Duck
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package org.jetbrains.kotlin.course.duck.shop.duck

data class JsDuck(val name: String, val description: String?, val hasKotlinAttribute: Boolean)
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.action

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.functions.change

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.getDescription
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.mode

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.utils.GameMode
import org.jetbrains.kotlin.course.duck.shop.utils.toJsDuck
import org.springframework.web.bind.annotation.CrossOrigin
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.jetbrains.kotlin.course.duck.shop.utils

import duck.shop.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.JsDuck
import org.jetbrains.kotlin.course.duck.shop.duck.Duck
import org.jetbrains.kotlin.course.duck.shop.functions.common.Body

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package org.jetbrains.kotlin.course.duck.shop.duck

data class JsDuck(val name: String, val description: String?, val hasKotlinAttribute: Boolean)
Loading

0 comments on commit 16692e0

Please sign in to comment.